; amd-gfx@lists.freedesktop.org
Subject: Re: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround
in amdgpu_virt
Hi Oak,
[Oak] I am not familiar about the power gating sequence but from first glance,
should the power gating sequence make sure that HW is ready (idle) for power
gating befo
; Huang, Ray ; Huang, Shimmer
; amd-gfx@lists.freedesktop.org
Subject: Re: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround
in amdgpu_virt
Hi Oak,
> [Oak] I am not familiar about the power gating sequence but from first
> glance, should the power gating sequence make sur
Behalf Of Christian
König
Sent: Wednesday, November 20, 2019 8:21 AM
To: Liu, Monk ; Zhu, Changfeng ; Xiao, Jack
; Zhou1, Tao ; Huang, Ray ; Huang,
Shimmer ; amd-gfx@lists.freedesktop.org
Subject: Re: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround
in amdgpu_virt
Hi Monk,
this is
; Huang, Ray
; Huang, Shimmer ; amd-gfx@lists.freedesktop.org
主题: Re: 答复: 答复: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore
workaround in amdgpu_virt
Hi Monk,
the KIQ is used to invalidate both the GFXHUB as well as the MMHUB on Vega.
Besides, amdgpu_virt_kiq_reg_write_reg_wait() is not dea
1/2] drm/amdgpu: invalidate mmhub semphore workaround
in amdgpu_virt
Hi Monk,
this is a fix for power gating the MMHUB.
Basic problem is that the MMHUB can power gate while an invalidation is in
progress
[Oak] I am not familiar about the power gating sequence but from first glance,
should the
you can put
> semaphore r/w out side of this routine and only Put them around the VM
> invalidate logic
>
> Thanks
>
> -邮件原件-
> 发件人: Zhu, Changfeng
> 发送时间: 2019年11月20日 22:17
> 收件人: Koenig, Christian ; Liu, Monk
> ; Xiao, Jack ; Zhou1, Tao
> ; Huang,
perienced ? and how to
repro the bug
2) if you do hit some issues, did you verified that your patch can fix it ?
besides
/Monk
-邮件原件-
发件人: amd-gfx 代表
Changfeng.Zhu
发送时间: 2019年11月20日 17:14
收件人: Koenig, Christian ; Xiao, Jack
; Zhou1, Tao ; Huang, Ray
; Huang, Shimmer ;
amd-gfx@lists.freed
From: Christian König
Sent: Wednesday, November 20, 2019 10:39 PM
To: Liu, Monk ; Zhu, Changfeng ;
Koenig, Christian ; Xiao, Jack ;
Zhou1, Tao ; Huang, Ray ; Huang, Shimmer
; amd-gfx@lists.freedesktop.org
Subject: Re: 答复: 答复: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore
workaround in amdgpu
ore r/w out side of this routine and only
Put them around the VM invalidate logic
Thanks
-邮件原件-
发件人: Zhu, Changfeng
发送时间: 2019年11月20日 22:17
收件人: Koenig, Christian ; Liu, Monk ; Xiao, Jack
; Zhou1, Tao ; Huang, Ray ; Huang,
Shimmer ; amd-gfx@lists.freedesktop.org
主题: RE: 答复: 答复: [PATCH
> 发送时间: 2019年11月20日 21:21
> 收件人: Liu, Monk ; Zhu, Changfeng
> ; Xiao, Jack ; Zhou1, Tao
> ; Huang, Ray ; Huang, Shimmer
> ; amd-gfx@lists.freedesktop.org
> 主题: Re: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore
> workaround in amdgpu_virt
>
> Hi Monk,
>
>
ower gating
?? I didn't tell from the patch ,
is there another change that use KIQ to grab the semaphore before trying to do
power gating as well ?
thanks
-邮件原件-
发件人: Christian König
发送时间: 2019年11月20日 22:00
收件人: Liu, Monk ; Koenig, Christian
; Zhu, Changfeng ; Xiao, Jack
uang, Shimmer
> ; amd-gfx@lists.freedesktop.org
> 主题: Re: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore
> workaround in amdgpu_virt
>
> Hi Monk,
>
> this is a fix for power gating the MMHUB.
>
> Basic problem is that the MMHUB can power gate while an inval
an fix it ?
besides
/Monk
-邮件原件-
发件人: amd-gfx 代表 Changfeng.Zhu
发送时间: 2019年11月20日 17:14
收件人: Koenig, Christian ; Xiao, Jack
; Zhou1, Tao ; Huang, Ray
; Huang, Shimmer ;
amd-gfx@lists.freedesktop.org
抄送: Zhu, Changfeng
主题: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround in
amdgpu_
???
-邮件原件-
发件人: Koenig, Christian
发送时间: 2019年11月20日 21:21
收件人: Liu, Monk ; Zhu, Changfeng ;
Xiao, Jack ; Zhou1, Tao ; Huang, Ray
; Huang, Shimmer ;
amd-gfx@lists.freedesktop.org
主题: Re: 答复: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround in
amdgpu_virt
Hi Monk,
this is
nks
/Monk
-邮件原件-
发件人: Christian König
发送时间: 2019年11月20日 19:24
收件人: Zhu, Changfeng ; Koenig, Christian ; Xiao, Jack
; Zhou1, Tao ; Huang, Ray ; Huang, Shimmer
; amd-gfx@lists.freedesktop.org; Deng, Emily ; Liu, Monk
主题: Re: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround in
amdgp
Christian
; Xiao, Jack ; Zhou1, Tao
; Huang, Ray ; Huang, Shimmer
; amd-gfx@lists.freedesktop.org; Deng, Emily
; Liu, Monk
主题: Re: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround in
amdgpu_virt
Hi Changfeng,
[adding Monk and Emily as well].
I thought more about this and came to th
eet with ?
-邮件原件-
发件人: Christian König
发送时间: 2019年11月20日 19:24
收件人: Zhu, Changfeng ; Koenig, Christian
; Xiao, Jack ; Zhou1, Tao
; Huang, Ray ; Huang, Shimmer
; amd-gfx@lists.freedesktop.org; Deng, Emily
; Liu, Monk
主题: Re: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaroun
人: amd-gfx 代表 Changfeng.Zhu
发送时间: 2019年11月20日 17:14
收件人: Koenig, Christian ; Xiao, Jack ; Zhou1, Tao
; Huang, Ray ; Huang, Shimmer ;
amd-gfx@lists.freedesktop.org
抄送: Zhu, Changfeng
主题: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround in amdgpu_virt
From: changzhu
It may lose gpuvm
Xiao, Jack
; Zhou1, Tao ; Huang, Ray
; Huang, Shimmer ;
amd-gfx@lists.freedesktop.org
抄送: Zhu, Changfeng
主题: [PATCH 1/2] drm/amdgpu: invalidate mmhub semphore workaround in amdgpu_virt
From: changzhu
It may lose gpuvm invalidate acknowldege state across power-gating off cycle.
To avoid this iss
Hi Changfeng,
[adding Monk and Emily as well].
I thought more about this and came to the conclusion that this won't
work and might result in a lockup as well.
We are using the KIQ on SRIOV for GPUVM invalidation because we need an
atomic read/modify/write cycle since we found that the invali
From: changzhu
It may lose gpuvm invalidate acknowldege state across power-gating off
cycle. To avoid this issue in virt invalidation, add semaphore acquire
before invalidation and semaphore release after invalidation.
Change-Id: Ie98304e475166b53eed033462d76423b6b0fc25b
Signed-off-by: changzhu
21 matches
Mail list logo
