Based on confirmation from Christian, it seems my understanding of the
design was not correct, and user must add a list of registers to dump.
That resolves most of my comments automatically, @Amar, please fix a max
register condition in the loop, to handle the negative testing case and
the uin
>> User only update the list of reg offsets on init, there is no
>> predefined reg offset from kernel code.
I missed this comment in the last patch, and this makes me a bit
confused. During the design phase, did we agree to have this whole list
loaded from user ? which means that if user doesn'
On 2/8/2022 2:39 PM, Somalapuram, Amaranath wrote:
On 2/8/2022 4:43 PM, Sharma, Shashank wrote:
I thought we spoke and agreed about:
- Not doing dynamic memory allocation during a reset call,
as there is a redesign debugfs call will happen during the application
initialization and not duri
On 2/8/2022 4:43 PM, Sharma, Shashank wrote:
I thought we spoke and agreed about:
- Not doing dynamic memory allocation during a reset call,
as there is a redesign debugfs call will happen during the application
initialization and not during reset.
- Not doing string operations, but just dum
Amar,
Apart from the long comment,there are a few more bugs in the patch,
which I have mentioned here inline. Please check them out.
- Shashank
On 2/8/2022 9:18 AM, Christian König wrote:
Am 08.02.22 um 09:16 schrieb Somalapuram Amaranath:
List of register to be populated for dump collectio
-gfx@lists.freedesktop.org
Cc: Koenig, Christian ; Deucher, Alexander
; Sharma, Shashank ;
Somalapuram, Amaranath
Subject: [PATCH 1/2] drm/amdgpu: add debugfs for reset registers list
List of register to be populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
Am 08.02.22 um 09:16 schrieb Somalapuram Amaranath:
List of register to be populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 60 +
List of register to be populated for dump collection during the GPU reset.
Signed-off-by: Somalapuram Amaranath
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 60 +
2 files changed, 63 insertions(+)
diff --git a/drivers
