Re: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation

2018-02-01 Thread Christian König
-Original Message- From: Bridgman, John Sent: Thursday, February 01, 2018 3:37 PM To: Alex Deucher; Koenig, Christian Cc: amd-gfx list; Liu, Shaoyun Subject: RE: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation If it helps, my recollection was that Intel was also pushing some pre

RE: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation

2018-02-01 Thread Liu, Shaoyun
, Shaoyun Subject: RE: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation If it helps, my recollection was that Intel was also pushing some pre-silicon support code upstream. Agree that if the changes get big/messy/invasive we should rethink this, but my impression is that the changes can be

RE: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation

2018-02-01 Thread Bridgman, John
Original Message- >From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of >Alex Deucher >Sent: Thursday, February 01, 2018 3:31 PM >To: Koenig, Christian >Cc: amd-gfx list; Liu, Shaoyun >Subject: Re: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation > &g

Re: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation

2018-02-01 Thread Alex Deucher
On Thu, Feb 1, 2018 at 3:19 PM, Christian König wrote: > I don't think we should push any emulation specific code upstream. > > Nobody outside of AMD can test anything of that not actually make any use of > it. It makes it much easier to maintain the code however and debug things on the emulator

Re: [PATCH 1/2] drm/amdgpu: Set module parameter for emulation

2018-02-01 Thread Christian König
I don't think we should push any emulation specific code upstream. Nobody outside of AMD can test anything of that not actually make any use of it. Regards, Christian. Am 01.02.2018 um 21:15 schrieb Shaoyun Liu: During emulation period, use the directly load for firmware also only enable the

[PATCH 1/2] drm/amdgpu: Set module parameter for emulation

2018-02-01 Thread Shaoyun Liu
During emulation period, use the directly load for firmware also only enable the GFX , SDMA and necessary common, gmc, ih IP block Signed-off-by: Shaoyun Liu Change-Id: I325910fa06be4060725f404e471cc79daaf343c3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 10 +- 1 file changed, 9 inser