Re: [PATCH 1/2] drm/amdgpu: Implement get num of hops between two xgmi device

2019-04-23 Thread Kuehling, Felix
It seems to me that amdgpu_hive_info is a driver-internal structure, but the psp_xpmi_topology structures are an interface with the PSP that may change in future ASIC generations. So on second thought, adding the psp_xgmi_topology structures to the psp_xgmi_context (or amdgpu_hive_info) like th

[PATCH 1/2] drm/amdgpu: Implement get num of hops between two xgmi device

2019-04-23 Thread Liu, Shaoyun
KFD need to provide the info for upper level to determine the data path Change-Id: Idc809e8f3381b9222dd7be96539522d440f3ee7d Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 1/2] drm/amdgpu: Implement get num of hops between two xgmi device

2019-04-23 Thread Liu, Shaoyun
comments inline. On 2019-04-23 2:09 p.m., Kuehling, Felix wrote: > See inline. > > On 2019-04-17 2:58 p.m., Liu, Shaoyun wrote: >> KFD need to provide the info for upper level to determine the data path >> >> Change-Id: Idc809e8f3381b9222dd7be96539522d440f3ee7d >> Signed-off-by: shaoyunl >> --- >

Re: [PATCH 1/2] drm/amdgpu: Implement get num of hops between two xgmi device

2019-04-23 Thread Kuehling, Felix
See inline. On 2019-04-17 2:58 p.m., Liu, Shaoyun wrote: > KFD need to provide the info for upper level to determine the data path > > Change-Id: Idc809e8f3381b9222dd7be96539522d440f3ee7d > Signed-off-by: shaoyunl > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 15 +++ > drive

Re: [PATCH 1/2] drm/amdgpu: Implement get num of hops between two xgmi device

2019-04-22 Thread Liu, Shaoyun
ping On 2019-04-17 2:58 p.m., Liu, Shaoyun wrote: > KFD need to provide the info for upper level to determine the data path > > Change-Id: Idc809e8f3381b9222dd7be96539522d440f3ee7d > Signed-off-by: shaoyunl > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 15 +++ > drivers/gpu/

[PATCH 1/2] drm/amdgpu: Implement get num of hops between two xgmi device

2019-04-17 Thread Liu, Shaoyun
KFD need to provide the info for upper level to determine the data path Change-Id: Idc809e8f3381b9222dd7be96539522d440f3ee7d Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 15 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdgpu/