Re: [PATCH 1/2] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Lazar, Lijo
On 11/13/2024 11:27 AM, Alex Deucher wrote: > On Tue, Nov 12, 2024 at 11:59 PM Lazar, Lijo wrote: >> >> >> >> On 11/13/2024 1:58 AM, Alex Deucher wrote: >>> smu->workload_mask is IP specific and should not be messed with in >>> the common code. The mask bits vary across SMU versions. >>> >>> Mo

Re: [PATCH 1/2] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Alex Deucher
On Tue, Nov 12, 2024 at 11:59 PM Lazar, Lijo wrote: > > > > On 11/13/2024 1:58 AM, Alex Deucher wrote: > > smu->workload_mask is IP specific and should not be messed with in > > the common code. The mask bits vary across SMU versions. > > > > Move all handling of smu->workload_mask in to the backe

Re: [PATCH 1/2] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Lazar, Lijo
On 11/13/2024 1:58 AM, Alex Deucher wrote: > smu->workload_mask is IP specific and should not be messed with in > the common code. The mask bits vary across SMU versions. > > Move all handling of smu->workload_mask in to the backends and > simplify the code. Store the user's preference in smu-

[PATCH 1/2] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Alex Deucher
smu->workload_mask is IP specific and should not be messed with in the common code. The mask bits vary across SMU versions. Move all handling of smu->workload_mask in to the backends and simplify the code. Store the user's preference in smu->power_profile_mode which will be reflected in sysfs. F