RE: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-20 Thread Liu, Monk
; amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun Subject: Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback You should be able to save the plain text email and pass that to "git am". It's trivial with Thunderbird on a Linux system. If you're usi

Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-19 Thread Felix Kuehling
riday, December 20, 2019 10:09 AM To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun ; Liu, Monk Subject: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback The intention of the pre_reset callback is to update the driver state to reflect that all user mode queues are preempte

RE: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-19 Thread Liu, Monk
rg Cc: Liu, Shaoyun ; Liu, Monk Subject: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback The intention of the pre_reset callback is to update the driver state to reflect that all user mode queues are preempted and the HIQ is destroyed. However we should not actually pre

Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-19 Thread Felix Kuehling
Shaoyun.liu *From:* Kuehling, Felix *Sent:* December 19, 2019 9:21:08 PM *To:* amd-gfx@lists.freedesktop.org ; Liu, Monk ; Liu, Shaoyun ; Grodzovsky, Andrey *Subject:* Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardwa

Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-19 Thread Liu, Shaoyun
; Grodzovsky, Andrey Subject: Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback [+Andrey] Hi Shaoyun, Monk, and Andrey, I tested this on my bare-metal Vega10 system. GPU reset (using BACO) is flaky on this system with and without this patch. The first reset seems to

Re: [PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-19 Thread Felix Kuehling
[+Andrey] Hi Shaoyun, Monk, and Andrey, I tested this on my bare-metal Vega10 system. GPU reset (using BACO) is flaky on this system with and without this patch. The first reset seems to work OK, the second one fails in different ways. In theory this change should be an improvement as it elim

[PATCH 1/1] drm/amdkfd: Don't touch the hardware in pre_reset callback

2019-12-19 Thread Felix Kuehling
The intention of the pre_reset callback is to update the driver state to reflect that all user mode queues are preempted and the HIQ is destroyed. However we should not actually preempt any queues or otherwise touch the hardware because it is presumably hanging. The impending reset will take care o