Re: [PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-29 Thread Alex Deucher
On Tue, Sep 29, 2020 at 2:59 PM Luben Tuikov wrote: > > On 2020-09-29 10:57 a.m., Alex Deucher wrote: > >>> +#ifndef __VANGOGH_IP_OFFSET_H__ > >>> +#define __VANGOGH_IP_OFFSET_H__ > >>> + > >>> +#define MAX_INSTANCE8 > >>> +#define MAX_SEGMENT

Re: [PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-29 Thread Luben Tuikov
On 2020-09-29 10:57 a.m., Alex Deucher wrote: >>> +#ifndef __VANGOGH_IP_OFFSET_H__ >>> +#define __VANGOGH_IP_OFFSET_H__ >>> + >>> +#define MAX_INSTANCE8 >>> +#define MAX_SEGMENT 6 >> No. No "max". Use "num" instead, as:

[PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-29 Thread Alex Deucher
From: Huang Rui This patch adds vangogh_reg_base_init function to init the register base for van gogh. v2: make vangogh_reg_base_init void, align equality sign Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |

Re: [PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-29 Thread Alex Deucher
On Mon, Sep 28, 2020 at 4:49 PM Luben Tuikov wrote: > > On 2020-09-25 4:09 p.m., Alex Deucher wrote: > > From: Huang Rui > > > > This patch adds vangogh_reg_base_init function to init the register base for > > van gogh. > > > > Signed-off-by: Huang Rui > > Reviewed-by: Alex Deucher > > Signed-o

Re: [PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-28 Thread Luben Tuikov
On 2020-09-25 4:09 p.m., Alex Deucher wrote: > From: Huang Rui > > This patch adds vangogh_reg_base_init function to init the register base for > van gogh. > > Signed-off-by: Huang Rui > Reviewed-by: Alex Deucher > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/Makefile

[PATCH 05/45] drm/amdgpu: add vangogh_reg_base_init function for van gogh

2020-09-25 Thread Alex Deucher
From: Huang Rui This patch adds vangogh_reg_base_init function to init the register base for van gogh. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/Makefile |2 +- drivers/gpu/drm/amd/amdgpu/nv.h |