Re: [PATCH 02/22] drm/amdgpu: remove duplicated job_free_resources

2018-02-26 Thread Christian König
NAK, the job->fence is assigned a reference just the line before: job->fence = dma_fence_get(fence); When the fence ends up as a wild pointer in the SA we have a problem with fence reference counting somewhere, not a problem with freeing resources. Regards, Christian. Am 26.02.2018 um 06:1

[PATCH 02/22] drm/amdgpu: remove duplicated job_free_resources

2018-02-25 Thread Monk Liu
if a job is go through scheduler, it is forbidden to call job_free_resources after ib_schedule, becaust that would assign wild pointer of fence on the sa_bo->fence which could lead to weird bug Change-Id: Iad7ee011c641cb7357569cbce36fdc10f0ed911d Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/a