Re: [PATCH 00/20] drm/amdgpu: gfx off support

2018-04-19 Thread Huang Rui
On Fri, Apr 20, 2018 at 01:58:33AM +0800, Kuehling, Felix wrote: > On 2018-04-19 09:51 AM, Alex Deucher wrote: > > On Wed, Apr 18, 2018 at 8:22 PM, Huang Rui wrote: > >> GFXOFF is the new GPU feature that save power consumption. It used RLC to > >> poweroff the gfx engine dynamicly when there is n

Re: [PATCH 00/20] drm/amdgpu: gfx off support

2018-04-19 Thread Huang Rui
On Thu, Apr 19, 2018 at 09:51:29PM +0800, Alex Deucher wrote: > On Wed, Apr 18, 2018 at 8:22 PM, Huang Rui wrote: > > GFXOFF is the new GPU feature that save power consumption. It used RLC to > > poweroff the gfx engine dynamicly when there is no workload on gfx pipe and > > make > > gfx into "id

Re: [PATCH 00/20] drm/amdgpu: gfx off support

2018-04-19 Thread Alex Deucher
On Thu, Apr 19, 2018 at 1:58 PM, Felix Kuehling wrote: > On 2018-04-19 09:51 AM, Alex Deucher wrote: >> On Wed, Apr 18, 2018 at 8:22 PM, Huang Rui wrote: >>> GFXOFF is the new GPU feature that save power consumption. It used RLC to >>> poweroff the gfx engine dynamicly when there is no workload o

Re: [PATCH 00/20] drm/amdgpu: gfx off support

2018-04-19 Thread Felix Kuehling
On 2018-04-19 09:51 AM, Alex Deucher wrote: > On Wed, Apr 18, 2018 at 8:22 PM, Huang Rui wrote: >> GFXOFF is the new GPU feature that save power consumption. It used RLC to >> poweroff the gfx engine dynamicly when there is no workload on gfx pipe and >> make >> gfx into "idle" state. >> 1. Add t

Re: [PATCH 00/20] drm/amdgpu: gfx off support

2018-04-19 Thread Alex Deucher
On Wed, Apr 18, 2018 at 8:22 PM, Huang Rui wrote: > GFXOFF is the new GPU feature that save power consumption. It used RLC to > poweroff the gfx engine dynamicly when there is no workload on gfx pipe and > make > gfx into "idle" state. > 1. Add three additional RLC ucodes, and use psp to load the

Re: [PATCH 00/20] drm/amdgpu: gfx off support

2018-04-19 Thread Christian König
I can't judge technical correctness, but coding style, commit messages etc..  look good on first glance. Series is Acked-by: Christian König . Regards, Christian. Am 19.04.2018 um 02:22 schrieb Huang Rui: GFXOFF is the new GPU feature that save power consumption. It used RLC to poweroff the g

[PATCH 00/20] drm/amdgpu: gfx off support

2018-04-18 Thread Huang Rui
GFXOFF is the new GPU feature that save power consumption. It used RLC to poweroff the gfx engine dynamicly when there is no workload on gfx pipe and make gfx into "idle" state. 1. Add three additional RLC ucodes, and use psp to load them. 2. Revise RLC save restore list. 3. Enable CGPG (GFX power