Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-31 Thread Daniel Vetter
On Tue, Jul 30, 2024 at 02:06:08PM +0200, Christian König wrote: > Am 30.07.24 um 10:36 schrieb Daniel Vetter: > > > In the end you have a really nice circle dependency. > > Maybe a follow up, so for arb robustness or vk context where we want the > > context to die and refuse to accept any more job

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-30 Thread Christian König
Am 30.07.24 um 10:36 schrieb Daniel Vetter: In the end you have a really nice circle dependency. Maybe a follow up, so for arb robustness or vk context where we want the context to die and refuse to accept any more jobs: We can get at that error somehow? I think that's really the only worry I ha

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-30 Thread Daniel Vetter
On Mon, Jul 29, 2024 at 08:43:05PM +0200, Christian König wrote: > Am 26.07.24 um 16:21 schrieb Daniel Vetter: > > On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: > > > The current implementation of drm_sched_start uses a hardcoded > > > -ECANCELED to dispose of a job when the pare

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-29 Thread Christian König
Am 26.07.24 um 16:21 schrieb Daniel Vetter: On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANC

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-29 Thread Christian König
Am 26.07.24 um 14:30 schrieb Matthew Brost: On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANC

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-26 Thread Daniel Vetter
On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: > The current implementation of drm_sched_start uses a hardcoded > -ECANCELED to dispose of a job when the parent/hw fence is NULL. > This results in drm_sched_job_done being called with -ECANCELED for > each job with a NULL parent in

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-26 Thread Matthew Brost
On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: > The current implementation of drm_sched_start uses a hardcoded > -ECANCELED to dispose of a job when the parent/hw fence is NULL. > This results in drm_sched_job_done being called with -ECANCELED for > each job with a NULL parent in

[PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-26 Thread Christian König
The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANCELED for each job with a NULL parent in the pending list, making it difficult to distinguish between recovery me