Re: [PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-04 Thread Jay Cornwall
On 10/4/2024 04:42, Lancelot SIX wrote: + * Copyright 2024 Advanced Micro Devices, Inc. I am not really sure bout the year policy in the kernel, but all the content here is dated from before 2024.  The vast majority is taken form the cwsr_trap_handler_gfx10.asm file (copyright started in 201

Re: [PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-04 Thread Lancelot SIX
Hi Jay, Thanks for doing this. I have minor comments inlined below. Overall, this new version assembles to the same binary, so no functional change expected. Best, Lancelot. On 03/10/2024 20:31, Jay Cornwall wrote: gfx12 derivatives will have substantially different trap handler implement

RE: [PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-03 Thread Kim, Jonathan
[Public] + David/Sreekant for KFD impact Acked-by: Jonathan Kim > -Original Message- > From: Cornwall, Jay > Sent: Thursday, October 3, 2024 3:31 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cornwall, Jay ; Six, Lancelot > ; Kim, Jonathan > Subject: [PATCH] d

[PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-03 Thread Jay Cornwall
gfx12 derivatives will have substantially different trap handler implementations from gfx10/gfx11. Add a separate source file for gfx12+ and remove unneeded conditional code. No functional change. Signed-off-by: Jay Cornwall Cc: Lancelot Six Cc: Jonathan Kim --- .../amd/amdkfd/cwsr_trap_handl