Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-11 Thread Jay Cornwall
On 1/11/2024 11:25, Kim, Jonathan wrote: >> This looks OK. The compiler must be warning about a potential problem >> here, not a definite one. >> >> Question for Jon, how does the firmware encode the error code in the >> context ID? I see these macros: >> >> #define KFD_DEBUG_CP_BAD_OP_ECODE_MASK

RE: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-11 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Thursday, January 11, 2024 11:03 AM > To: Ma, Jun ; Ma, Jun ; amd- > g...@lists.freedesktop.org; Kim, Jonathan > Subject: Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning > > [+Jon] > >

Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-11 Thread Felix Kuehling
[+Jon] On 2024-01-11 01:05, Ma, Jun wrote: Hi Felix, On 1/10/2024 11:57 PM, Felix Kuehling wrote: On 2024-01-10 04:39, Ma Jun wrote: There is following shift-out-of-bounds warning if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: M

Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-10 Thread Ma, Jun
Hi Felix, On 1/10/2024 11:57 PM, Felix Kuehling wrote: > On 2024-01-10 04:39, Ma Jun wrote: >> There is following shift-out-of-bounds warning if ecode=0. >> "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned >> int'" >> >> Signed-off-by: Ma Jun >> --- >> include/uapi/l

Re: [PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-10 Thread Felix Kuehling
On 2024-01-10 04:39, Ma Jun wrote: There is following shift-out-of-bounds warning if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: Ma Jun --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH] drm/amdkfd: Fix the shift-out-of-bounds warning

2024-01-10 Thread Ma Jun
There is following shift-out-of-bounds warning if ecode=0. "shift exponent 4294967295 is too large for 64-bit type 'long long unsigned int'" Signed-off-by: Ma Jun --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/kfd_ioctl.