Re: [PATCH] drm/amdkfd: Fix circular lock in nocpsch path

2021-06-16 Thread Pan, Xinhui
> 2021年6月16日 12:36,Kuehling, Felix 写道: > > Am 2021-06-16 um 12:01 a.m. schrieb Pan, Xinhui: >>> 2021年6月16日 02:22,Kuehling, Felix 写道: >>> >>> [+Xinhui] >>> >>> >>> Am 2021-06-15 um 1:50 p.m. schrieb Amber Lin: Calling free_mqd inside of destroy_queue_nocpsch_locked can cause a circ

Re: [PATCH] drm/amdkfd: Fix circular lock in nocpsch path

2021-06-16 Thread Felix Kuehling
Am 2021-06-16 um 12:01 a.m. schrieb Pan, Xinhui: >> 2021年6月16日 02:22,Kuehling, Felix 写道: >> >> [+Xinhui] >> >> >> Am 2021-06-15 um 1:50 p.m. schrieb Amber Lin: >>> Calling free_mqd inside of destroy_queue_nocpsch_locked can cause a >>> circular lock. destroy_queue_nocpsch_locked is called under a

Re: [PATCH] drm/amdkfd: Fix circular lock in nocpsch path

2021-06-16 Thread Pan, Xinhui
> 2021年6月16日 02:22,Kuehling, Felix 写道: > > [+Xinhui] > > > Am 2021-06-15 um 1:50 p.m. schrieb Amber Lin: >> Calling free_mqd inside of destroy_queue_nocpsch_locked can cause a >> circular lock. destroy_queue_nocpsch_locked is called under a DQM lock, >> which is taken in MMU notifiers, potent

Re: [PATCH] drm/amdkfd: Fix circular lock in nocpsch path

2021-06-15 Thread Felix Kuehling
[+Xinhui] Am 2021-06-15 um 1:50 p.m. schrieb Amber Lin: > Calling free_mqd inside of destroy_queue_nocpsch_locked can cause a > circular lock. destroy_queue_nocpsch_locked is called under a DQM lock, > which is taken in MMU notifiers, potentially in FS reclaim context. > Taking another lock, whic

[PATCH] drm/amdkfd: Fix circular lock in nocpsch path

2021-06-15 Thread Amber Lin
Calling free_mqd inside of destroy_queue_nocpsch_locked can cause a circular lock. destroy_queue_nocpsch_locked is called under a DQM lock, which is taken in MMU notifiers, potentially in FS reclaim context. Taking another lock, which is BO reservation lock from free_mqd, while causing an FS reclai