I got it, the IH sw_fini is done later than DCE while your other patch cleans
up timer in DCE sw_fini.
Maybe you can call amdgpu_irq_put() here, anyway your patch is already in:)
—
Sincerely Yours,
Pixel
On 16/11/2017, 5:28 PM, "Ding, Pixel" wrote:
>Hi Monk,
>
>I’m not for sure what issu
Hi Monk,
I’m not for sure what issue you are fixing. The timer should be cancelled while
the IRQ is put to disable vblank . However there is a known rmmod issue fixed
with “02d319e drm/amdgpu/virtual_dce: Remove the rmmod error message”.
Can you take a look at that patch or tell why or in which
virtual DCE Timer structure is already released
after its sw_fini(), so we need to cancel the
its Timer in hw_fini() otherwise the Timer canceling
is missed.
v2:
use for loop and num_crtc to replace original code
Change-Id: I03d6ca7aa07591d287da379ef4fe008f06edaff6
Signed-off-by: Monk Liu
Review
virtual DCE Timer structure is already released
after its sw_fini(), so we need to cancel the
its Timer in hw_fini() otherwise the Timer canceling
is missed.
v2:
use for loop and num_crtc to replace original code
Change-Id: I03d6ca7aa07591d287da379ef4fe008f06edaff6
Signed-off-by: Monk Liu
Review