RE: [PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-02-01 Thread Zeng, Oak
Reviewed-by: Oak Zeng Thanks, Oak -Original Message- From: amd-gfx On Behalf Of Yang, Philip Sent: Thursday, January 31, 2019 9:26 AM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

Re: [PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-01-31 Thread Christian König
Am 31.01.19 um 15:25 schrieb Yang, Philip: amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, so it is needed to use irq version spin_lock to avoid deadlock. Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4 Good catch, but your signed-of-by line is missin

[PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-01-31 Thread Yang, Philip
amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, so it is needed to use irq version spin_lock to avoid deadlock. Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4 --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 delet