Re: [PATCH] drm/amdgpu: restore dcc bo tilling configs while moving

2024-07-02 Thread Marek Olšák
data_format == 13, 15, and 23 are also invalid. Marek On Tue, Jul 2, 2024 at 12:05 PM Marek Olšák wrote: > > I think the change should fix invalid values passed from userspace. > > max_com == 3 should be clamped to 2. > data_format == 0 || data_format > 24 should do 2 things: set > data_format t

Re: [PATCH] drm/amdgpu: restore dcc bo tilling configs while moving

2024-07-02 Thread Marek Olšák
I think the change should fix invalid values passed from userspace. max_com == 3 should be clamped to 2. data_format == 0 || data_format > 24 should do 2 things: set data_format to 10, set num_format to 0. Marek On Tue, Jul 2, 2024 at 9:43 AM Marek Olšák wrote: > > Reviewed-by: Marek Olšák > >

Re: [PATCH] drm/amdgpu: restore dcc bo tilling configs while moving

2024-07-02 Thread Marek Olšák
Reviewed-by: Marek Olšák On Sun, Jun 30, 2024 at 11:35 PM Min, Frank wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Frank Min > > While moving buffer which as dcc tiling config, it is needed to restore its > original dcc tiling. > > 1. extend copy flag to cover t

Re: [PATCH] drm/amdgpu: restore dcc bo tilling configs while moving

2024-07-01 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Min, Frank Sent: Sunday, June 30, 2024 11:17 PM To: Deucher, Alexander ; Olsak, Marek ; Koenig, Christian ; Zhang, Hawking ; Gao, Likun ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: restore dcc bo

[PATCH] drm/amdgpu: restore dcc bo tilling configs while moving

2024-06-30 Thread Min, Frank
[AMD Official Use Only - AMD Internal Distribution Only] From: Frank Min While moving buffer which as dcc tiling config, it is needed to restore its original dcc tiling. 1. extend copy flag to cover tiling bits 2. add logic to restore original dcc tiling config Signed-off-by: Frank Min ---