Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_gfx.c

2023-05-23 Thread Alex Deucher
On Tue, May 23, 2023 at 2:31 PM Srinivasan Shanmugam wrote: > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ‘amdgpu_gfx_disable_kcq’: > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:497:6: warning: variable ‘j’ set but > not used [-Wunused-but-set-variable] > 497 | int j; > | ^ >

[PATCH] drm/amdgpu: Remove unused variable in amdgpu_gfx.c

2023-05-23 Thread Srinivasan Shanmugam
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ‘amdgpu_gfx_disable_kcq’: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:497:6: warning: variable ‘j’ set but not used [-Wunused-but-set-variable] 497 | int j; | ^ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ‘amdgpu_gfx_disable_k

Re: [PATCH] drm/amdgpu: remove unused variable num_xcc

2023-05-22 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 22, 2023 at 8:30 AM Tom Rix wrote: > > gcc with W=1 reports > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:2138:13: error: variable > ‘num_xcc’ set but not used [-Werror=unused-but-set-variable] > 2138 | int num_xcc; > | ^~~ > > This

[PATCH] drm/amdgpu: remove unused variable num_xcc

2023-05-22 Thread Tom Rix
gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:2138:13: error: variable ‘num_xcc’ set but not used [-Werror=unused-but-set-variable] 2138 | int num_xcc; | ^~~ This variable is not used so remove it. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/am

[PATCH] drm/amdgpu: remove unused variable mmhub_v1_8_mmea_cgtt_clk_cntl_reg

2023-05-22 Thread Tom Rix
gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c:760:23: error: ‘mmhub_v1_8_mmea_cgtt_clk_cntl_reg’ defined but not used [-Werror=unused-const-variable=] 760 | static const uint32_t mmhub_v1_8_mmea_cgtt_clk_cntl_reg[] = { | ^~

[PATCH] drm/amdgpu: remove unused variable j

2023-04-20 Thread Tom Rix
gcc with W=1 reports drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ‘amdgpu_gfx_mqd_sw_fini’: drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:451:16: error: variable ‘j’ set but not used [-Werror=unused-but-set-variable] 451 | int i, j; |^ drivers/gpu/drm/amd/amdgp

RE: [PATCH] drm/amdgpu: remove unused variable

2023-03-01 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: bobzhou Sent: Thursday, March 2, 2023 2:44 PM To: amd-gfx@lists.freedesktop.org; Chen, Guchun ; Cui, Flora ; Shi, Leslie ; Ma, Jun Cc: Zhou, Bob Subject: [PATCH] drm/amdgpu: remove unused variable building with gcc

[PATCH] drm/amdgpu: remove unused variable

2023-03-01 Thread bobzhou
building with gcc and W=1 reports drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:7292:11: error: unused variable 'tmp' [-Werror=unused-variable] uint32_t tmp; ^~~ tmp is not used so remove it. Signed-off-by: bobzhou --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 - 1 file changed, 1 deleti

Re: [PATCH] drm/amdgpu: remove unused variable ring

2023-02-24 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 24, 2023 at 11:45 AM Tom Rix wrote: > > building with gcc and W=1 reports > drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:81:29: error: variable > ‘ring’ set but not used [-Werror=unused-but-set-variable] >81 | struct amdgpu_ring *ring; > |

[PATCH] drm/amdgpu: remove unused variable ring

2023-02-24 Thread Tom Rix
building with gcc and W=1 reports drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:81:29: error: variable ‘ring’ set but not used [-Werror=unused-but-set-variable] 81 | struct amdgpu_ring *ring; | ^~~~ ring is not used so remove it. Signed-off-by: Tom Rix ---

[PATCH] drm/amdgpu: remove unused variable channel_index

2023-02-24 Thread Tom Rix
building with gcc and W=1 reports drivers/gpu/drm/amd/amdgpu/umc_v8_10.c:437:37: error: variable ‘channel_index’ set but not used [-Werror=unused-but-set-variable] 437 | uint32_t eccinfo_table_idx, channel_index; | ^ channel_index i

Re: [PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread Christian König
Am 19.01.22 um 07:42 schrieb mziya: Remove set but unused variable. warning: variable 'umc_reg_offset' set but not used Signed-off-by: mziya You should use your full written name here. Apart from that nit the patch looks good to me. Christian. Reported-by: kernel test robot Reviewed-by:

[PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread mziya
Remove set but unused variable. warning: variable 'umc_reg_offset' set but not used Signed-off-by: mziya Reported-by: kernel test robot Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_

RE: [PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread Zhang, Hawking
Subject: [PATCH] drm/amdgpu: remove unused variable Remove set but unused variable. warning: variable 'umc_reg_offset' set but not used Signed-off-by: mziya Reported-by: kernel test robot --- drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 4 1 file changed, 4 deletions(-) diff --git a/d

[PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread mziya
Remove set but unused variable. warning: variable 'umc_reg_offset' set but not used Signed-off-by: mziya Reported-by: kernel test robot --- drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c b/drivers/gpu/drm/amd/a

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unmap()

2021-02-26 Thread Christian König
Am 26.02.21 um 05:24 schrieb Kevin Wang: clean up unsued variable in amdgpu_dma_buf_unmap(). Fixes: drm/amdgpu: Remove amdgpu_device arg from free_sgt api Signed-off-by: Kevin Wang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 1 file changed, 4

RE: [PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unmap()

2021-02-25 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Kevin Wang Sent: Friday, February 26, 2021 12:25 To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: [PATCH] drm/amdgpu: remove unused variable in

[PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unmap()

2021-02-25 Thread Kevin Wang
clean up unsued variable in amdgpu_dma_buf_unmap(). Fixes: drm/amdgpu: Remove amdgpu_device arg from free_sgt api Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drive

[PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-24 Thread Nirmoy Das
Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +-- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 5 files changed, 5 insert

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-23 Thread Nirmoy
Thanks Updated and pushed to  brahma HEAD:refs/for/amd-staging-drm-next On 10/23/19 5:21 PM, Koenig, Christian wrote: > Maybe say parameter instead of variable in the subject. > > Am 23.10.19 um 16:35 schrieb Nirmoy Das: >> Signed-off-by: Nirmoy Das > Apart from that Acked-by: Christian König >

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-23 Thread Koenig, Christian
Maybe say parameter instead of variable in the subject. Am 23.10.19 um 16:35 schrieb Nirmoy Das: > Signed-off-by: Nirmoy Das Apart from that Acked-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +-- > drivers/gpu/d

Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover

2018-05-24 Thread Christian König
Reviewed-by: Christian König as well. Christian. Am 23.05.2018 um 19:11 schrieb Andrey Grodzovsky: Reviewed-by: Andrey Grodzovsky Andrey On 05/23/2018 01:08 PM, Harry Wentland wrote: It throws an unused variable warning. Signed-off-by: Harry Wentland ---   drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover

2018-05-23 Thread Andrey Grodzovsky
Reviewed-by: Andrey Grodzovsky Andrey On 05/23/2018 01:08 PM, Harry Wentland wrote: It throws an unused variable warning. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_devi

[PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover

2018-05-23 Thread Harry Wentland
It throws an unused variable warning. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index c1654a4dfd82..57a4f393ada3 100644 -