Re: [PATCH] drm/amdgpu: remap hdp coherency registers for vi on carrizo

2020-08-19 Thread Huang Rui
On Wed, Aug 19, 2020 at 11:28:01PM +0800, Kuehling, Felix wrote: > Am 2020-08-19 um 11:01 a.m. schrieb Huang Rui: > > On Wed, Aug 19, 2020 at 10:36:05PM +0800, Kuehling, Felix wrote: > >> Just for Carrizo, HDP flushing doesn't make a lot of sense because we > >> don't use HDP to access the framebuf

Re: [PATCH] drm/amdgpu: remap hdp coherency registers for vi on carrizo

2020-08-19 Thread Felix Kuehling
Am 2020-08-19 um 11:01 a.m. schrieb Huang Rui: > On Wed, Aug 19, 2020 at 10:36:05PM +0800, Kuehling, Felix wrote: >> Just for Carrizo, HDP flushing doesn't make a lot of sense because we >> don't use HDP to access the framebuffer. > OK, so soc15 and later need use HDP to access the framebuffer from

Re: [PATCH] drm/amdgpu: remap hdp coherency registers for vi on carrizo

2020-08-19 Thread Huang Rui
On Wed, Aug 19, 2020 at 10:36:05PM +0800, Kuehling, Felix wrote: > Just for Carrizo, HDP flushing doesn't make a lot of sense because we > don't use HDP to access the framebuffer. OK, so soc15 and later need use HDP to access the framebuffer from user space. May I know why? > > The code you're c

Re: [PATCH] drm/amdgpu: remap hdp coherency registers for vi on carrizo

2020-08-19 Thread Felix Kuehling
Just for Carrizo, HDP flushing doesn't make a lot of sense because we don't use HDP to access the framebuffer. The code you're changing doesn't look Carrizo-specific, but VI-specific. So it would affect Fiji and Polaris as well. We already support Fiji and Polaris dGPUs with KFD, apparently withou

[PATCH] drm/amdgpu: remap hdp coherency registers for vi on carrizo

2020-08-19 Thread Huang Rui
Carrzio also needs remap HDP_MEM_COHERENCY_FLUSH_CNTL and HDP_REG_COHERENCY_FLUSH_CNTL to the empty page in mmio space. Then user mode is able to do flush hdp as well. It will used for force dgpu path on carrizo. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/vi.c | 18 +++--