RE: [PATCH] drm/amdgpu: protect ring overrun

2020-04-23 Thread Tao, Yintian
Hi Christian Thanks. I will remove the initialization of r. Best Regards Yintian Tao -Original Message- From: Christian König Sent: 2020年4月23日 20:22 To: Tao, Yintian ; Koenig, Christian ; Liu, Monk ; Liu, Shaoyun Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

Re: [PATCH] drm/amdgpu: protect ring overrun

2020-04-23 Thread Christian König
Am 23.04.20 um 11:06 schrieb Yintian Tao: Wait for the oldest sequence on the ring to be signaled in order to make sure there will be no command overrun. v2: fix coding stype and remove abs operation One nit pick below, with that fixed the patch is Reviewed-by: Christian König Signed-off

[PATCH] drm/amdgpu: protect ring overrun

2020-04-23 Thread Yintian Tao
Wait for the oldest sequence on the ring to be signaled in order to make sure there will be no command overrun. v2: fix coding stype and remove abs operation Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 22

Re: [PATCH] drm/amdgpu: protect ring overrun

2020-04-23 Thread Christian König
Am 23.04.20 um 06:22 schrieb Yintian Tao: Wait for the oldest sequence on the ring to be signaled in order to make sure there will be no command overrun. One technical problem and a few style suggestions below. Apart from that looks good to me. Signed-off-by: Yintian Tao --- drivers/gpu

[PATCH] drm/amdgpu: protect ring overrun

2020-04-22 Thread Yintian Tao
Wait for the oldest sequence on the ring to be signaled in order to make sure there will be no command overrun. Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 17 +++-- drivers/gpu/drm/amd/amdgpu/amdg