Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-07 Thread Marek Olšák
On Wed, Aug 7, 2024 at 4:21 AM Tvrtko Ursulin wrote: > > > On 04/08/2024 19:11, Marek Olšák wrote: > > On Thu, Aug 1, 2024 at 2:55 PM Marek Olšák wrote: > >> > >> On Thu, Aug 1, 2024, 03:37 Christian König > >> wrote: > >>> > >>> Am 01.08.24 um 08:53 schrieb Marek Olšák: > >>> > >>> On Thu, Aug

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-07 Thread Tvrtko Ursulin
On 04/08/2024 19:11, Marek Olšák wrote: On Thu, Aug 1, 2024 at 2:55 PM Marek Olšák wrote: On Thu, Aug 1, 2024, 03:37 Christian König wrote: Am 01.08.24 um 08:53 schrieb Marek Olšák: On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: On 8/1/2024 8:49 AM, Marek Olšák wrote: + /* He

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-04 Thread Marek Olšák
On Thu, Aug 1, 2024 at 2:55 PM Marek Olšák wrote: > > On Thu, Aug 1, 2024, 03:37 Christian König wrote: >> >> Am 01.08.24 um 08:53 schrieb Marek Olšák: >> >> On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: >>> >>> >>> On 8/1/2024 8:49 AM, Marek Olšák wrote: >>> >> + /* Header is at index 0

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-03 Thread Marek Olšák
On Fri, Aug 2, 2024 at 6:10 AM Lazar, Lijo wrote: > > > > On 8/2/2024 12:25 AM, Marek Olšák wrote: > > On Thu, Aug 1, 2024, 03:37 Christian König > > wrote: > > > > __ > > Am 01.08.24 um 08:53 schrieb Marek Olšák: > >> On Thu, Aug 1, 2024, 00:28 Khatri

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-02 Thread Lazar, Lijo
On 8/2/2024 12:25 AM, Marek Olšák wrote: > On Thu, Aug 1, 2024, 03:37 Christian König > wrote: > > __ > Am 01.08.24 um 08:53 schrieb Marek Olšák: >> On Thu, Aug 1, 2024, 00:28 Khatri, Sunil > > wrote: >> >> >> On

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-01 Thread Marek Olšák
On Thu, Aug 1, 2024, 03:37 Christian König wrote: > Am 01.08.24 um 08:53 schrieb Marek Olšák: > > On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: > >> >> On 8/1/2024 8:49 AM, Marek Olšák wrote: >> >> + /* Header is at index 0, followed by num_nops - 1 NOP packet's >> */ >> >> + for (

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-01 Thread Christian König
Am 01.08.24 um 08:53 schrieb Marek Olšák: On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: On 8/1/2024 8:49 AM, Marek Olšák wrote: >> +       /* Header is at index 0, followed by num_nops - 1 NOP packet's */ >> +       for (i = 1; i < num_nop; i++) >> +               amdgpu_

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Marek Olšák
On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: > > On 8/1/2024 8:49 AM, Marek Olšák wrote: > > On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri > wrote: > >> Adding NOP packets one by one in the ring > >> does not use the CP efficiently. > >> > >> Solution: > >> Use CP optimization while adding NOP

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Khatri, Sunil
On 8/1/2024 8:54 AM, Marek Olšák wrote: On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri wrote: Adding NOP packets one by one in the ring does not use the CP efficiently. Solution: Use CP optimization while adding NOP packet's so PFP can discard NOP packets based on information of count from the

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Khatri, Sunil
On 8/1/2024 8:52 AM, Marek Olšák wrote: On Wed, Jul 31, 2024 at 11:19 PM Marek Olšák wrote: On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri wrote: Adding NOP packets one by one in the ring does not use the CP efficiently. Solution: Use CP optimization while adding NOP packet's so PFP can disc

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Khatri, Sunil
On 8/1/2024 8:49 AM, Marek Olšák wrote: On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri wrote: Adding NOP packets one by one in the ring does not use the CP efficiently. Solution: Use CP optimization while adding NOP packet's so PFP can discard NOP packets based on information of count from the

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Marek Olšák
On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri wrote: > > Adding NOP packets one by one in the ring > does not use the CP efficiently. > > Solution: > Use CP optimization while adding NOP packet's so PFP > can discard NOP packets based on information of count > from the Header instead of fetching al

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Marek Olšák
On Wed, Jul 31, 2024 at 11:19 PM Marek Olšák wrote: > > On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri wrote: > > > > Adding NOP packets one by one in the ring > > does not use the CP efficiently. > > > > Solution: > > Use CP optimization while adding NOP packet's so PFP > > can discard NOP packets

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-31 Thread Marek Olšák
On Tue, Jul 30, 2024 at 8:43 AM Sunil Khatri wrote: > > Adding NOP packets one by one in the ring > does not use the CP efficiently. > > Solution: > Use CP optimization while adding NOP packet's so PFP > can discard NOP packets based on information of count > from the Header instead of fetching al

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-30 Thread Christian König
Am 30.07.24 um 14:43 schrieb Sunil Khatri: Adding NOP packets one by one in the ring does not use the CP efficiently. Solution: Use CP optimization while adding NOP packet's so PFP can discard NOP packets based on information of count from the Header instead of fetching all NOP packets one by on

[PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-07-30 Thread Sunil Khatri
Adding NOP packets one by one in the ring does not use the CP efficiently. Solution: Use CP optimization while adding NOP packet's so PFP can discard NOP packets based on information of count from the Header instead of fetching all NOP packets one by one. Cc: Christian König Cc: Pierre-Eric Pell