Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Huang Rui
Ah, sorry, this is my mistake to miss the "return 0;". Marek, thanks a lot to point out. I will take care next time. Christian, I see you already send the patch to fix it. Thanks. Thanks, Rui On Wed, Sep 14, 2016 at 10:36:16PM +0800, Koenig, Christian wrote: > Thanks for that info, I was busy mo

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Christian König
Thanks for that info, I was busy most of the day bisecting this regression as well. Yeah, the bug is rather obvious, there is a "return 0;" in the good case missing here. So after loading the firmware we release it again. I will hack together a patch, just give me a minute. Christian. Am

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Marek Olšák
Hi, This patch causes a massive performance drop (by a factor of 100) followed by GPU hangs with F1 2015 (it needs more than 3GB of memory, the card has 2GB). The game normally works really well (30+ FPS on Polaris11 2GB, 40+ FPS on Tonga 2GB). It should be fixed or the commit should be reverted

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-12 Thread Christian König
Am 12.09.2016 um 04:16 schrieb Huang Rui: Clean up the codes to move the release handles into fail labels. Signed-off-by: Huang Rui Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-)

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-11 Thread zhoucm1
On 2016年09月12日 10:16, Huang Rui wrote: Clean up the codes to move the release handles into fail labels. Signed-off-by: Huang Rui Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff -

[PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-11 Thread Huang Rui
Clean up the codes to move the release handles into fail labels. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amd