Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Christian König
Am 07.11.23 um 16:14 schrieb Alex Deucher: On Tue, Nov 7, 2023 at 9:52 AM Christian König wrote: This is only needed for certain UVD/VCE hardware/firmware versions. We currently enable it for all UVD and VCE versions. Leo needs to decide that, but I would rather like to keep the call to crea

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Alex Deucher
On Tue, Nov 7, 2023 at 2:47 PM Alex Deucher wrote: > > On Tue, Nov 7, 2023 at 10:14 AM Alex Deucher wrote: > > > > On Tue, Nov 7, 2023 at 9:52 AM Christian König > > wrote: > > > > > > This is only needed for certain UVD/VCE hardware/firmware versions. > > > > We currently enable it for all UVD

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Alex Deucher
On Tue, Nov 7, 2023 at 10:14 AM Alex Deucher wrote: > > On Tue, Nov 7, 2023 at 9:52 AM Christian König > wrote: > > > > This is only needed for certain UVD/VCE hardware/firmware versions. > > We currently enable it for all UVD and VCE versions. > > > > > Leo needs to decide that, but I would rath

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Michel Dänzer
On 11/7/23 15:47, Alex Deucher wrote: > On Tue, Nov 7, 2023 at 9:19 AM Alex Deucher wrote: >> On Tue, Nov 7, 2023 at 5:52 AM Christian König >> wrote: >>> Am 03.11.23 um 23:10 schrieb Alex Deucher: On Fri, Nov 3, 2023 at 4:17 PM Alex Deucher wrote: > On Thu, Oct 26, 2023 at 4:17 PM Lube

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Alex Deucher
On Tue, Nov 7, 2023 at 9:52 AM Christian König wrote: > > This is only needed for certain UVD/VCE hardware/firmware versions. We currently enable it for all UVD and VCE versions. > > Leo needs to decide that, but I would rather like to keep the call to > create the entity in the HW IP specific f

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Christian König
This is only needed for certain UVD/VCE hardware/firmware versions. Leo needs to decide that, but I would rather like to keep the call to create the entity in the HW IP specific files. Regards, Christian. Am 07.11.23 um 15:47 schrieb Alex Deucher: On Tue, Nov 7, 2023 at 9:19 AM Alex Deucher

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Alex Deucher
On Tue, Nov 7, 2023 at 9:19 AM Alex Deucher wrote: > > On Tue, Nov 7, 2023 at 5:52 AM Christian König > wrote: > > > > Am 03.11.23 um 23:10 schrieb Alex Deucher: > > > On Fri, Nov 3, 2023 at 4:17 PM Alex Deucher wrote: > > >> On Thu, Oct 26, 2023 at 4:17 PM Luben Tuikov wrote: > > >>> Pushed to

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Alex Deucher
On Tue, Nov 7, 2023 at 5:52 AM Christian König wrote: > > Am 03.11.23 um 23:10 schrieb Alex Deucher: > > On Fri, Nov 3, 2023 at 4:17 PM Alex Deucher wrote: > >> On Thu, Oct 26, 2023 at 4:17 PM Luben Tuikov wrote: > >>> Pushed to drm-misc-next. > >> BTW, I'm seeing the following on older GPUs wit

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-07 Thread Christian König
Am 03.11.23 um 23:10 schrieb Alex Deucher: On Fri, Nov 3, 2023 at 4:17 PM Alex Deucher wrote: On Thu, Oct 26, 2023 at 4:17 PM Luben Tuikov wrote: Pushed to drm-misc-next. BTW, I'm seeing the following on older GPUs with VCE and UVD even with this patch: [ 11.886024] amdgpu :0a:00.0: [d

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-03 Thread Alex Deucher
On Fri, Nov 3, 2023 at 4:17 PM Alex Deucher wrote: > > On Thu, Oct 26, 2023 at 4:17 PM Luben Tuikov wrote: > > > > Pushed to drm-misc-next. > > BTW, I'm seeing the following on older GPUs with VCE and UVD even with > this patch: > [ 11.886024] amdgpu :0a:00.0: [drm] *ERROR* drm_sched_job_in

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-11-03 Thread Alex Deucher
On Thu, Oct 26, 2023 at 4:17 PM Luben Tuikov wrote: > > Pushed to drm-misc-next. BTW, I'm seeing the following on older GPUs with VCE and UVD even with this patch: [ 11.886024] amdgpu :0a:00.0: [drm] *ERROR* drm_sched_job_init: entity has no rq! [ 11.886028] amdgpu :0a:00.0: [drm:amdg

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-26 Thread Alex Deucher
Thanks! On Thu, Oct 26, 2023 at 4:17 PM Luben Tuikov wrote: > > Pushed to drm-misc-next. > > Regards, > Luben > > On 2023-10-26 15:52, Luben Tuikov wrote: > > On 2023-10-26 15:32, Alex Deucher wrote: > >> On Thu, Oct 26, 2023 at 2:22 AM Christian König > >> wrote: > >>> > >>> Am 25.10.23 um 19:1

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-26 Thread Luben Tuikov
Pushed to drm-misc-next. Regards, Luben On 2023-10-26 15:52, Luben Tuikov wrote: > On 2023-10-26 15:32, Alex Deucher wrote: >> On Thu, Oct 26, 2023 at 2:22 AM Christian König >> wrote: >>> >>> Am 25.10.23 um 19:19 schrieb Alex Deucher: Rather than doing this in the IP code for the SDMA pagi

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-26 Thread Luben Tuikov
On 2023-10-26 15:32, Alex Deucher wrote: > On Thu, Oct 26, 2023 at 2:22 AM Christian König > wrote: >> >> Am 25.10.23 um 19:19 schrieb Alex Deucher: >>> Rather than doing this in the IP code for the SDMA paging >>> engine, move it up to the core device level init level. >>> This should fix the sch

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-26 Thread Alex Deucher
On Thu, Oct 26, 2023 at 2:22 AM Christian König wrote: > > Am 25.10.23 um 19:19 schrieb Alex Deucher: > > Rather than doing this in the IP code for the SDMA paging > > engine, move it up to the core device level init level. > > This should fix the scheduler init ordering. > > > > v2: drop extra pa

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-25 Thread Christian König
Am 25.10.23 um 19:19 schrieb Alex Deucher: Rather than doing this in the IP code for the SDMA paging engine, move it up to the core device level init level. This should fix the scheduler init ordering. v2: drop extra parens v3: drop SDMA helpers Tested-by: Luben Tuikov Signed-off-by: Alex Deuc

[PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-25 Thread Alex Deucher
Rather than doing this in the IP code for the SDMA paging engine, move it up to the core device level init level. This should fix the scheduler init ordering. v2: drop extra parens v3: drop SDMA helpers Tested-by: Luben Tuikov Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_d

[PATCH] drm/amdgpu: move buffer funcs setting up a level

2023-10-25 Thread Alex Deucher
Rather than doing this in the IP code for the SDMA paging engine, move it up to the core device level init level. This should fix the scheduler init ordering. v2: drop extra parens Tested-by: Luben Tuikov Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +

Re: [PATCH] drm/amdgpu: move buffer funcs setting up a level (v2)

2023-10-24 Thread Christian König
Am 25.10.23 um 06:24 schrieb Luben Tuikov: From: Alex Deucher Rather than doing this in the IP code for the SDMA paging engine, move it up to the core device level init level. This should fix the scheduler init ordering. v2: Fix checkpatch parens complaint; long lines. (Luben) Signed-off-by:

[PATCH] drm/amdgpu: move buffer funcs setting up a level (v2)

2023-10-24 Thread Luben Tuikov
From: Alex Deucher Rather than doing this in the IP code for the SDMA paging engine, move it up to the core device level init level. This should fix the scheduler init ordering. v2: Fix checkpatch parens complaint; long lines. (Luben) Signed-off-by: Alex Deucher Tested-by: Luben Tuikov --- d