Re: [PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-04-10 Thread Alex Deucher
On Tue, Apr 8, 2025 at 5:53 AM Christian König wrote: > > Am 08.04.25 um 10:23 schrieb ZhenGuo Yin: > > Kernel doorbell BOs needs to be freed before ttm_fini. > > > > Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages") > > Signed-off-by: ZhenGuo Yin > > At least from my point that pa

Re: [PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-04-09 Thread Christian König
Am 08.04.25 um 10:23 schrieb ZhenGuo Yin: > Kernel doorbell BOs needs to be freed before ttm_fini. > > Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages") > Signed-off-by: ZhenGuo Yin At least from my point that patch seems to make a lot of sense, so feel free to add Reviewed-by: Ch

[PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-04-08 Thread ZhenGuo Yin
Kernel doorbell BOs needs to be freed before ttm_fini. Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages") Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

RE: [PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-04-02 Thread Yin, ZhenGuo (Chris)
Core team, SRDC -Original Message- From: Yin, ZhenGuo (Chris) Sent: Tuesday, April 1, 2025 11:41 AM To: Koenig, Christian ; amd-gfx@lists.freedesktop.org; Shi, Leslie Cc: Sharma, Shashank ; Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: fix warning of drm_mm_clean Hi Leslie Any

RE: [PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-03-31 Thread Yin, ZhenGuo (Chris)
Sent: Monday, March 31, 2025 8:07 PM To: Yin, ZhenGuo (Chris) ; amd-gfx@lists.freedesktop.org Cc: Sharma, Shashank ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: fix warning of drm_mm_clean Am 31.03.25 um 13:26 schrieb ZhenGuo Yin: > Kernel doorbell BOs needs to be freed before ttm_f

[PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-03-31 Thread ZhenGuo Yin
Kernel doorbell BOs needs to be freed before ttm_fini. Fixes: 54c30d2a8def ("drm/amdgpu: create kernel doorbell pages") Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/am

Re: [PATCH] drm/amdgpu: fix warning of drm_mm_clean

2025-03-31 Thread Christian König
Am 31.03.25 um 13:26 schrieb ZhenGuo Yin: > Kernel doorbell BOs needs to be freed before ttm_fini. Good catch, but does anybody remember why we have the drm_dev_enter()/drm_dev_exit() here? It's clearly for hotplug, but it doesn't make sense to have the amdgpu_doorbell_fini() under it as far as