RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery

2020-08-20 Thread Zhang, Hawking
d-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Koenig, Christian Subject: RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery [AMD Public Use] Hi, Hawking, When RAS uncorrectable error happens, RAS interrupt will trigger a GPU recovery. At the same

Re: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery

2020-08-20 Thread Christian König
: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery [AMD Public Use] Hi Dennis, Can you elaborate the case that driver re-enter GPU recovery in sGPU system? I'm wondering whether this is a valid case or we shall prevent this from the beginning. Regards, Hawking -Ori

RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery

2020-08-20 Thread Li, Dennis
, August 20, 2020 4:24 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Koenig, Christian Cc: Li, Dennis Subject: RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery [AMD Public Use] Hi Dennis, Can you elaborate the case that driver re

RE: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery

2020-08-20 Thread Zhang, Hawking
10:21 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Koenig, Christian Cc: Li, Dennis Subject: [PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery in single gpu system, if driver reenter gpu recovery, amdgpu_device_lock_adev will r

[PATCH] drm/amdgpu: fix the nullptr issue when reenter GPU recovery

2020-08-19 Thread Dennis Li
in single gpu system, if driver reenter gpu recovery, amdgpu_device_lock_adev will return false, but hive is nullptr now. Signed-off-by: Dennis Li diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 82242e2f5658..81b1d9a1dca0 100644 --- a/d