Re: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-26 Thread Luben Tuikov
On 2020-02-25 18:40, Luben Tuikov wrote: > On 2020-02-25 8:57 a.m., Huang Rui wrote: >> Since 6643ba1 frame control packets are only issued in presence of secure >> IB(s). >> This causes hangs on some hardware (eg: Raven1). This patch restores the >> unconditionnal frame control packets issuing, t

Re: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-25 Thread Luben Tuikov
On 2020-02-25 8:57 a.m., Huang Rui wrote: > Since 6643ba1 frame control packets are only issued in presence of secure > IB(s). > This causes hangs on some hardware (eg: Raven1). This patch restores the > unconditionnal frame control packets issuing, that's to keep the per-IB logic > regarding the

Re: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-25 Thread Luben Tuikov
Thanks for fixing this Ray. I think we can simplify the logic introduced in this patch. Regards, Luben On 2020-02-25 8:57 a.m., Huang Rui wrote: > Since 6643ba1 frame control packets are only issued in presence of secure > IB(s). > This causes hangs on some hardware (eg: Raven1). This patch res

RE: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-25 Thread Liu, Aaron
ayer, Pierre-eric ; Huang, Ray Subject: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag Since 6643ba1 frame control packets are only issued in presence of secure IB(s). This causes hangs on some hardware (eg: Raven1). This patch restores the unconditionnal frame control pac

Re: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-25 Thread Alex Deucher
On Tue, Feb 25, 2020 at 8:58 AM Huang Rui wrote: > > Since 6643ba1 frame control packets are only issued in presence of secure > IB(s). > This causes hangs on some hardware (eg: Raven1). This patch restores the > unconditionnal frame control packets issuing, that's to keep the per-IB logic > rega

Re: [PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-25 Thread Pierre-Eric Pelloux-Prayer
Hi Ray, I confirm that this fixes the hang I had when running libdrm's amdgpu_test. Thanks! Tested-by: Pierre-Eric Pelloux-Prayer On 25/02/2020 14:57, Huang Rui wrote: > Since 6643ba1 frame control packets are only issued in presence of secure > IB(s). > This causes hangs on some hardware (eg

[PATCH] drm/amdgpu: fix the gfx hang while use per-ib secure flag

2020-02-25 Thread Huang Rui
Since 6643ba1 frame control packets are only issued in presence of secure IB(s). This causes hangs on some hardware (eg: Raven1). This patch restores the unconditionnal frame control packets issuing, that's to keep the per-IB logic regarding the secure flag. Fixes: 6643ba1 drm/amdgpu: Move to a pe