Re: [PATCH] drm/amdgpu: fix retry loop test

2023-09-07 Thread Alex Deucher
niel Vetter ; Lazar, Lijo > > ; Kamal, Asad ; Zhang, > > Hawking ; Limonciello, Mario > > ; amd-gfx@lists.freedesktop.org; kernel- > > janit...@vger.kernel.org > > Subject: [PATCH] drm/amdgpu: fix retry loop test > > > > This loop will exit with "retry&quo

RE: [PATCH] drm/amdgpu: fix retry loop test

2023-09-06 Thread Quan, Evan
55 PM > To: Quan, Evan ; Wang, Yang(Kevin) > > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter ; Lazar, Lijo > ; Kamal, Asad ; Zhang, > Hawking ; Limonciello, Mario > ; amd-gfx@lists.freedesktop.org; kernel- > janit...@vger.kernel.

[PATCH] drm/amdgpu: fix retry loop test

2023-09-06 Thread Dan Carpenter
This loop will exit with "retry" set to -1 if it fails but the code checks for if "retry" is zero. Fix this by changing post-op to a pre-op. --retry vs retry--. Fixes: e01eeffc3f86 ("drm/amd/pm: avoid driver getting empty metrics table for the first time") Signed-off-by: Dan Carpenter --- Obvi