Re: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

2017-09-02 Thread Christian König
] drm/amdgpu: fix placement flags in amdgpu_ttm_bind Thanks for the fix. I still don't quite understand how this works. We still call ttm_bo_move_ttm for a pinned BO. Maybe the function name is misleading. As I understand it, this doesn't move the memory physically. It just changes the GA

RE: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

2017-09-01 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Felix Kuehling > Sent: Friday, September 01, 2017 3:18 PM > To: Christian König; amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Subject: Re: [PATCH] drm/amdgpu: f

Re: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

2017-09-01 Thread Felix Kuehling
Thanks for the fix. I still don't quite understand how this works. We still call ttm_bo_move_ttm for a pinned BO. Maybe the function name is misleading. As I understand it, this doesn't move the memory physically. It just changes the GART address mapping? All that's needed is maintaining the flags

RE: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

2017-09-01 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Friday, September 01, 2017 3:24 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix; Russell, Kent > Subject: [PATCH] drm/amdgpu: f

[PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

2017-09-01 Thread Christian König
From: Christian König Otherwise we lose the NO_EVICT flag and can try to evict pinned BOs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/a