RE: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread Deucher, Alexander
Sent: Monday, September 26, 2016 11:17 AM To: 'Christian König'; StDenis, Tom; Cui, Flora Cc: Huang, Ray; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping Maybe it would be cleaner to just pass 0 to amdgpu_vm_frag_ptes() or remove

RE: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread Deucher, Alexander
@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping The function called is either amdgpu_vm_do_set_ptes() or amdgpu_vm_do_copy_ptes(). But that is actually rather unrelated to the local handling of addr in the function changed. The point here

Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread Christian König
--- *From:* amd-gfx on behalf of Christian König *Sent:* Monday, September 26, 2016 09:29 *To:* Cui, Flora *Cc:* Huang, Ray; amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping Yeah, that wouldn't really help but just make th

Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread StDenis, Tom
.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping Yeah, that wouldn't really help but just make the problem more unlikely to happen once more. Anyway Tom St confirmed that the patch seems to work for the open stack. Anybody brave enough to

Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread Christian König
Yeah, that wouldn't really help but just make the problem more unlikely to happen once more. Anyway Tom St confirmed that the patch seems to work for the open stack. Anybody brave enough to throw an rb on this so that I can commit it? Thanks, Christian. Am 26.09.2016 um 11:16 schrieb Flora Cu

Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread Flora Cui
please ignore this patch. it actually revert the gtt mgr changes. On Mon, Sep 26, 2016 at 03:19:01PM +0800, Flora Cui wrote: > On Sun, Sep 25, 2016 at 11:55:13AM +0200, Christian König wrote: > > From: Christian König > > > > Otherwise we will look at the wrong place in the IB when GART > > mapp

Re: [PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-26 Thread Flora Cui
On Sun, Sep 25, 2016 at 11:55:13AM +0200, Christian König wrote: > From: Christian König > > Otherwise we will look at the wrong place in the IB when GART > mappings are split into smaller updates. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + > 1 fil

[PATCH] drm/amdgpu: fix addr handling in amdgpu_vm_bo_update_mapping

2016-09-25 Thread Christian König
From: Christian König Otherwise we will look at the wrong place in the IB when GART mappings are split into smaller updates. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/d