Re: [PATCH] drm/amdgpu: cleanup amdgpu_vm_flush v5

2025-04-10 Thread Christian König
Am 10.04.25 um 05:52 schrieb SRINIVASAN SHANMUGAM: > > On 4/9/2025 7:16 PM, SRINIVASAN SHANMUGAM wrote: >> >> On 4/9/2025 7:11 PM, SRINIVASAN SHANMUGAM wrote: >>> >>> On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 4:15 PM, Christian König wrote: > This reverts commit c2c

Re: [PATCH] drm/amdgpu: cleanup amdgpu_vm_flush v5

2025-04-09 Thread SRINIVASAN SHANMUGAM
On 4/9/2025 7:16 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 7:11 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 4:15 PM, Christian König wrote: This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out that this has some negati

Re: [PATCH] drm/amdgpu: cleanup amdgpu_vm_flush v5

2025-04-09 Thread SRINIVASAN SHANMUGAM
On 4/9/2025 7:11 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 4:15 PM, Christian König wrote: This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out that this has some negative consequences for some workloads. Instead check

Re: [PATCH] drm/amdgpu: cleanup amdgpu_vm_flush v5

2025-04-09 Thread SRINIVASAN SHANMUGAM
On 4/9/2025 6:45 PM, SRINIVASAN SHANMUGAM wrote: On 4/9/2025 4:15 PM, Christian König wrote: This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out that this has some negative consequences for some workloads. Instead check if the cleaner shader should run directly. While

Re: [PATCH] drm/amdgpu: cleanup amdgpu_vm_flush v5

2025-04-09 Thread SRINIVASAN SHANMUGAM
On 4/9/2025 4:15 PM, Christian König wrote: This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out that this has some negative consequences for some workloads. Instead check if the cleaner shader should run directly. While at it remove amdgpu_vm_need_pipeline_sync(), we also

[PATCH] drm/amdgpu: cleanup amdgpu_vm_flush v5

2025-04-09 Thread Christian König
This reverts commit c2cc3648ba517a6c270500b5447d5a1efdad5936. Turned out that this has some negative consequences for some workloads. Instead check if the cleaner shader should run directly. While at it remove amdgpu_vm_need_pipeline_sync(), we also check again if the VMID has seen a GPU reset sin