RE: [PATCH] drm/amdgpu: always reset the asic in suspend (v2)

2021-11-15 Thread Quan, Evan
[AMD Official Use Only] Acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Saturday, November 13, 2021 12:26 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu: always reset th

Re: [PATCH] drm/amdgpu: always reset the asic in suspend

2021-11-15 Thread Deucher, Alexander
with the multiple freeze and thaw cycles. Alex From: Christian König Sent: Monday, November 15, 2021 8:41 AM To: Alex Deucher ; Deucher, Alexander Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: always reset the asic in suspend I was just about to write

Re: [PATCH] drm/amdgpu: always reset the asic in suspend (v2)

2021-11-15 Thread Alex Deucher
On Mon, Nov 15, 2021 at 2:50 AM Lazar, Lijo wrote: > > > > On 11/12/2021 9:55 PM, Alex Deucher wrote: > > If the platform suspend happens to fail and the power rail > > is not turned off, the GPU will be in an unknown state on > > resume, so reset the asic so that it will be in a known > > good st

Re: [PATCH] drm/amdgpu: always reset the asic in suspend

2021-11-15 Thread Christian König
I was just about to write up my concern as well. IIRC we used to have that and it didn't really worked that well and we switched to resetting the GPU on driver load instead if initializing it doesn't work of hand. Christian. Am 12.11.21 um 17:19 schrieb Alex Deucher: Actually, ignore this f

Re: [PATCH] drm/amdgpu: always reset the asic in suspend (v2)

2021-11-14 Thread Lazar, Lijo
On 11/12/2021 9:55 PM, Alex Deucher wrote: If the platform suspend happens to fail and the power rail is not turned off, the GPU will be in an unknown state on resume, so reset the asic so that it will be in a known good state on resume even if the platform suspend failed. Any more backgrou

Re: [PATCH] drm/amdgpu: always reset the asic in suspend (v2)

2021-11-12 Thread Luben Tuikov
Acked-by: Luben Tuikov On 2021-11-12 11:25, Alex Deucher wrote: > If the platform suspend happens to fail and the power rail > is not turned off, the GPU will be in an unknown state on > resume, so reset the asic so that it will be in a known > good state on resume even if the platform suspend

[PATCH] drm/amdgpu: always reset the asic in suspend (v2)

2021-11-12 Thread Alex Deucher
If the platform suspend happens to fail and the power rail is not turned off, the GPU will be in an unknown state on resume, so reset the asic so that it will be in a known good state on resume even if the platform suspend failed. v2: handle s0ix Signed-off-by: Alex Deucher --- drivers/gpu/drm/

Re: [PATCH] drm/amdgpu: always reset the asic in suspend

2021-11-12 Thread Alex Deucher
Actually, ignore this for now. This will likely cause problems with S0ix. Alex On Fri, Nov 12, 2021 at 11:18 AM Alex Deucher wrote: > > If the platform suspend happens to fail and the power rail > is not turned off, the GPU will be in an unknown state on > resume, so reset the asic so that it w

[PATCH] drm/amdgpu: always reset the asic in suspend

2021-11-12 Thread Alex Deucher
If the platform suspend happens to fail and the power rail is not turned off, the GPU will be in an unknown state on resume, so reset the asic so that it will be in a known good state on resume even if the platform suspend failed. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu