RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-02 Thread Yu, Lang
ect: Re: [PATCH] drm/amdgpu: add support to SMU debug option > > >On 2021-12-01 8:11 a.m., Christian König wrote: >> Adding Andrey as well. >> >> Am 01.12.21 um 12:37 schrieb Yu, Lang: >>> [SNIP] >>>>>>>>> + BUG_ON(unlikely(smu->s

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lazar, Lijo
Subject: RE: [PATCH] drm/amdgpu: add support to SMU debug option [AMD Official Use Only] -Original Message- From: amd-gfx On Behalf Of Yu, Lang Sent: Wednesday, December 1, 2021 7:37 PM To: Koenig, Christian ; Christian König ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
t;> ; amd-gfx@lists.freedesktop.org >> Cc: Deucher, Alexander ; Lazar, Lijo >> ; Huang, Ray >> Subject: RE: [PATCH] drm/amdgpu: add support to SMU debug option >> >> [AMD Official Use Only] >> >> >> >> >-Original Message- >> >From

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Quan, Evan
;; amd-gfx@lists.freedesktop.org > >Cc: Deucher, Alexander ; Lazar, Lijo > >; Huang, Ray > >Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option > > > >Am 01.12.21 um 12:20 schrieb Yu, Lang: > >> [AMD Official Use Only] > >> > >>>

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Andrey Grodzovsky
On 2021-12-01 8:11 a.m., Christian König wrote: Adding Andrey as well. Am 01.12.21 um 12:37 schrieb Yu, Lang: [SNIP] + BUG_ON(unlikely(smu->smu_debug_mode) && res); BUG_ON() really crashes the kernel and is only allowed if we prevent further data corruption with that. Most of the time WARN

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Adding Andrey as well. Am 01.12.21 um 12:37 schrieb Yu, Lang: [SNIP] + BUG_ON(unlikely(smu->smu_debug_mode) && res); BUG_ON() really crashes the kernel and is only allowed if we prevent further data corruption with that. Most of the time WARN_ON() is more appropriate, but I can't fully

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
n >>> ; amd-gfx@lists.freedesktop.org >>> Cc: Deucher, Alexander ; Lazar, Lijo >>> ; Huang, Ray >>> Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option >>> >>> Am 01.12.21 um 11:44 schrieb Yu, Lang: >>>> [AMD Official U

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option Am 01.12.21 um 10:24 schrieb Lang Yu: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
; amd-gfx@lists.freedesktop.org >>> Cc: Deucher, Alexander ; Lazar, Lijo >>> ; Huang, Ray >>> Subject: Re: [PATCH] drm/amdgpu: add support to SMU debug option >>> >>> Am 01.12.21 um 10:24 schrieb Lang Yu: >>>> To maintain system error

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Lazar, Lijo >Sent: Wednesday, December 1, 2021 6:46 PM >To: Yu, Lang ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Huang, Ray >; Koenig, Christian >Subject: Re: [PATCH] drm/amdgpu: add support to SMU d

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
support to SMU debug option Am 01.12.21 um 10:24 schrieb Lang Yu: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lazar, Lijo
support to SMU debug option On 12/1/2021 2:54 PM, Lang Yu wrote: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Koenig, Christian >Sent: Wednesday, December 1, 2021 5:30 PM >To: Yu, Lang ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Lazar, Lijo >; Huang, Ray >Subject: Re: [PATCH] drm/amdgpu: add support to S

RE: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Yu, Lang
[AMD Official Use Only] >-Original Message- >From: Lazar, Lijo >Sent: Wednesday, December 1, 2021 5:47 PM >To: Yu, Lang ; amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Huang, Ray >; Koenig, Christian >Subject: Re: [PATCH] drm/amdgpu: add support to SMU d

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lazar, Lijo
On 12/1/2021 2:54 PM, Lang Yu wrote: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU errors fatal. It is disabled

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Huang Rui
On Wed, Dec 01, 2021 at 05:24:58PM +0800, Yu, Lang wrote: > To maintain system error state when SMU errors occurred, > which will aid in debugging SMU firmware issues, add SMU > debug option support. > > It can be enabled or disabled via amdgpu_smu_debug > debugfs file. When enabled, it makes SMU

Re: [PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Christian König
Am 01.12.21 um 10:24 schrieb Lang Yu: To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU errors fatal. It is disabled b

[PATCH] drm/amdgpu: add support to SMU debug option

2021-12-01 Thread Lang Yu
To maintain system error state when SMU errors occurred, which will aid in debugging SMU firmware issues, add SMU debug option support. It can be enabled or disabled via amdgpu_smu_debug debugfs file. When enabled, it makes SMU errors fatal. It is disabled by default. == Command Guide == 1, enab