RE: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-06-01 Thread Li, Samuel
I can see them now. Sam > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Samuel Li > Sent: Friday, June 01, 2018 5:10 PM > To: Michel Dänzer ; Liu, Leo > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/a

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-06-01 Thread Samuel Li
On 2018-05-31 12:30 PM, Michel Dänzer wrote: > On 2018-05-30 08:42 PM, Leo Liu wrote: >> There are four ioctls in this files, and DOC gives details of >> data structures for each of ioctls, and their functionalities. >> >> Signed-off-by: Leo Liu > > This isn't enough to actually make this part

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-06-01 Thread Michel Dänzer
On 2018-05-30 08:42 PM, Leo Liu wrote: > There are four ioctls in this files, and DOC gives details of > data structures for each of ioctls, and their functionalities. > > Signed-off-by: Leo Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 142 + > 1 file changed, 142

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-06-01 Thread Michel Dänzer
On 2018-05-31 08:02 PM, Leo Liu wrote: > On 05/31/2018 01:04 PM, Michel Dänzer wrote: >> On 2018-05-31 06:49 PM, Leo Liu wrote: >>> On 05/31/2018 12:47 PM, Michel Dänzer wrote: On 2018-05-31 06:39 PM, Leo Liu wrote: > On 05/31/2018 12:30 PM, Michel Dänzer wrote: >> On 2018-05-30 08:42

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Leo Liu
On 05/31/2018 01:04 PM, Michel Dänzer wrote: On 2018-05-31 06:49 PM, Leo Liu wrote: On 05/31/2018 12:47 PM, Michel Dänzer wrote: On 2018-05-31 06:39 PM, Leo Liu wrote: On 05/31/2018 12:30 PM, Michel Dänzer wrote: On 2018-05-30 08:42 PM, Leo Liu wrote: diff --git a/drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Michel Dänzer
On 2018-05-31 06:49 PM, Leo Liu wrote: > On 05/31/2018 12:47 PM, Michel Dänzer wrote: >> On 2018-05-31 06:39 PM, Leo Liu wrote: >>> On 05/31/2018 12:30 PM, Michel Dänzer wrote: On 2018-05-30 08:42 PM, Leo Liu wrote: > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > b/drivers/gpu/

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Leo Liu
On 05/31/2018 12:47 PM, Michel Dänzer wrote: On 2018-05-31 06:39 PM, Leo Liu wrote: On 05/31/2018 12:30 PM, Michel Dänzer wrote: On 2018-05-30 08:42 PM, Leo Liu wrote: diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 12f0d18c6ee8..343ff115cff

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Leo Liu
On 05/31/2018 12:39 PM, Leo Liu wrote: On 05/31/2018 12:30 PM, Michel Dänzer wrote: On 2018-05-30 08:42 PM, Leo Liu wrote: There are four ioctls in this files, and DOC gives details of data structures for each of ioctls, and their functionalities. Signed-off-by: Leo Liu This isn't enough

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Michel Dänzer
On 2018-05-31 06:39 PM, Leo Liu wrote: > On 05/31/2018 12:30 PM, Michel Dänzer wrote: >> On 2018-05-30 08:42 PM, Leo Liu wrote: > >>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c >>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c >>> index 12f0d18c6ee8..343ff115cff1 100644 >>> --- a/drivers/gpu/d

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Leo Liu
On 05/31/2018 12:30 PM, Michel Dänzer wrote: On 2018-05-30 08:42 PM, Leo Liu wrote: There are four ioctls in this files, and DOC gives details of data structures for each of ioctls, and their functionalities. Signed-off-by: Leo Liu This isn't enough to actually make this part of the generat

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Michel Dänzer
On 2018-05-30 08:42 PM, Leo Liu wrote: > There are four ioctls in this files, and DOC gives details of > data structures for each of ioctls, and their functionalities. > > Signed-off-by: Leo Liu This isn't enough to actually make this part of the generated documentation. It needs to be hooked up

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Leo Liu
On 05/31/2018 11:43 AM, Alex Deucher wrote: On Wed, May 30, 2018 at 2:42 PM, Leo Liu wrote: There are four ioctls in this files, and DOC gives details of data structures for each of ioctls, and their functionalities. Signed-off-by: Leo Liu A few comments below about readability. With thos

Re: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-31 Thread Alex Deucher
On Wed, May 30, 2018 at 2:42 PM, Leo Liu wrote: > There are four ioctls in this files, and DOC gives details of > data structures for each of ioctls, and their functionalities. > > Signed-off-by: Leo Liu A few comments below about readability. With those fixed: Reviewed-by: Alex Deucher > ---

[PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-05-30 Thread Leo Liu
There are four ioctls in this files, and DOC gives details of data structures for each of ioctls, and their functionalities. Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 142 + 1 file changed, 142 insertions(+) diff --git a/drivers/gpu/drm/amd/amdg