Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-26 Thread Christian König
Am 26.04.23 um 02:48 schrieb Chia-I Wu: Good catch, but you need some commit message here. Something like "Need to hold the lock while iterating the idr to make sure no context is destroyed." should be sufficient. Apart from that looks good to me. Regards, Christian. Signed-off-by: Chia-I

Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-26 Thread Greg KH
On Tue, Apr 25, 2023 at 05:48:27PM -0700, Chia-I Wu wrote: > Signed-off-by: Chia-I Wu > Cc: sta...@vger.kernel.org I know I can not take patches without any changelog text at all, maybe the DRM developers are more lax, but it's not a good idea at all. thanks, greg k-h

Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Chia-I Wu
On Tue, Apr 25, 2023 at 9:58 PM Greg KH wrote: > > On Tue, Apr 25, 2023 at 05:48:27PM -0700, Chia-I Wu wrote: > > Signed-off-by: Chia-I Wu > > Cc: sta...@vger.kernel.org > > I know I can not take patches without any changelog text at all, maybe > the DRM developers are more lax, but it's not a go

Re: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Chia-I Wu
Vetter > > ; Deucher, Alexander ; > > David Airlie ; Koenig, Christian > > > > Subject: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED > > > > Signed-off-by: Chia-I Wu > > Cc: sta...@vger.kernel.org > > --- > > drivers/gpu/drm/amd/amdgpu/

RE: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Chen, Guchun
ktop.org > Cc: Pan, Xinhui ; linux-ker...@vger.kernel.org; > sta...@vger.kernel.org; amd-gfx@lists.freedesktop.org; Daniel Vetter > ; Deucher, Alexander ; > David Airlie ; Koenig, Christian > > Subject: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED > > Sign

[PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Chia-I Wu
Signed-off-by: Chia-I Wu Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c index e9b45089a28a6..863b2a34b2d64 1006