Re: [PATCH] drm/amdgpu: Remove unnecessary NULL check

2025-01-03 Thread Felix Kuehling
On 2025-01-02 10:01, Kent Russell wrote: container_of cannot return NULL, so it is unnecessary to check for NULL after gem_to_amdgpu_bo, which just is a container_of call Signed-off-by: Kent Russell Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 ++ 1

[PATCH] drm/amdgpu: Remove unnecessary NULL check

2025-01-02 Thread Kent Russell
container_of cannot return NULL, so it is unnecessary to check for NULL after gem_to_amdgpu_bo, which just is a container_of call Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH] drm/amdgpu: Remove unnecessary NULL check

2024-01-16 Thread Christian König
Am 15.01.24 um 23:57 schrieb Felix Kuehling: A static checker pointed out, that bo_va->base.bo was already derefenced earlier in the same scope. Therefore this check is unnecessary here. Reported-by: Dan Carpenter Fixes: 79e7fdec71f2 ("drm/amdgpu: Auto-validate DMABuf imports in compute VMs") S

RE: [PATCH] drm/amdgpu: Remove unnecessary NULL check

2024-01-16 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Monday, January 15, 2024 5:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Dan Carpenter > Subject: [PATCH] drm/amdgpu: Re

[PATCH] drm/amdgpu: Remove unnecessary NULL check

2024-01-15 Thread Felix Kuehling
A static checker pointed out, that bo_va->base.bo was already derefenced earlier in the same scope. Therefore this check is unnecessary here. Reported-by: Dan Carpenter Fixes: 79e7fdec71f2 ("drm/amdgpu: Auto-validate DMABuf imports in compute VMs") Signed-off-by: Felix Kuehling --- drivers/gpu/