RE: [PATCH] drm/amdgpu: Fix the warning info when removing amdgpu device

2023-03-06 Thread Li, Lyndon
yak, Vitaly ; Deucher, Alexander > ; Koenig, Christian > > Subject: Re: [PATCH] drm/amdgpu: Fix the warning info when removing > amdgpu device > > The commit message reads a bit bumpy. Generally best practice are: > > Short (72 chars or less) summary > > More detailed ex

Re: [PATCH] drm/amdgpu: Fix the warning info when removing amdgpu device

2023-03-06 Thread Christian König
March 7, 2023 10:12 AM To: amd-gfx@lists.freedesktop.org Cc: Prosyak, Vitaly ; Koenig, Christian ; Deucher, Alexander ; Chen, Guchun ; Xu, Feifei ; Ma, Jun ; Li, Lyndon Subject: [PATCH] drm/amdgpu: Fix the warning info when removing amdgpu device Actually, the drm_dev_enter in psp_cmd_submit_buf

RE: [PATCH] drm/amdgpu: Fix the warning info when removing amdgpu device

2023-03-06 Thread Chen, Guchun
/amdgpu: Fix the warning info when removing amdgpu device Actually, the drm_dev_enter in psp_cmd_submit_buf does not protect anything. And it is not used to prevent concurrent access. If DRM device is unplugged, it will always check the condition in WARN_ON. We'd better not keep adding comman

[PATCH] drm/amdgpu: Fix the warning info when removing amdgpu device

2023-03-06 Thread lyndonli
Actually, the drm_dev_enter in psp_cmd_submit_buf does not protect anything. And it is not used to prevent concurrent access. If DRM device is unplugged, it will always check the condition in WARN_ON. We'd better not keep adding commands to the list. Simply moving the drm_dev_enter/drm_dev_exit hig