Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Grodzovsky, Andrey
o >>> >>>> -Original Message- >>>> From: Grodzovsky, Andrey >>>> Sent: 2019年9月12日 10:32 >>>> To: Chen, Guchun ; Zhou1, Tao >>>> ; amd-gfx@lists.freedesktop.org >>>> Cc: Deucher, Alexander >>>> Subje

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Christian König
年9月12日 10:32 To: Chen, Guchun ; Zhou1, Tao ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. That not what I meant. Let's say you handled one bad page interrupt and as a result have one bad page reserved. Now unrela

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Grodzovsky, Andrey
m the case you > mentioned. > > Regards, > Tao > >> -Original Message- >> From: Grodzovsky, Andrey >> Sent: 2019年9月12日 10:32 >> To: Chen, Guchun ; Zhou1, Tao >> ; amd-gfx@lists.freedesktop.org >> Cc: Deucher, Alexander >> Subjec

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Zhou1, Tao
> To: Chen, Guchun ; Zhou1, Tao > ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. > > That not what I meant. Let's say you handled one bad page interrupt and as > a result have one bad page reser

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Grodzovsky, Andrey
amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. Comment inline. Regards, Guchun -Original Message- From: Grodzovsky, Andrey Sent: Wednesday, September 11, 2019 10:41 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Chen, Guchun
Comment inline. Regards, Guchun -Original Message- From: Grodzovsky, Andrey Sent: Wednesday, September 11, 2019 10:41 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. On

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Grodzovsky, Andrey
ta_cb. >> Anyway, either way is OK and the patch is: >> >> Reviewed-by: Tao Zhou >> >>> -Original Message- >>> From: Andrey Grodzovsky >>> Sent: 2019年9月11日 3:41 >>> To: amd-gfx@lists.freedesktop.org >>> Cc: Chen, Guchun

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Grodzovsky, Andrey
K and the patch is: > > Reviewed-by: Tao Zhou > >> -Original Message- >> From: Andrey Grodzovsky >> Sent: 2019年9月11日 3:41 >> To: amd-gfx@lists.freedesktop.org >> Cc: Chen, Guchun ; Zhou1, Tao >> ; Deucher, Alexander >> ; Grodzovsky, An

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-10 Thread Chen, Guchun
- From: Andrey Grodzovsky Sent: Wednesday, September 11, 2019 3:41 AM To: amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhou1, Tao ; Deucher, Alexander ; Grodzovsky, Andrey Subject: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. Problem: amdgpu_ras_reserve_bad_pages was moved to amd

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-10 Thread Zhou1, Tao
To: amd-gfx@lists.freedesktop.org > Cc: Chen, Guchun ; Zhou1, Tao > ; Deucher, Alexander > ; Grodzovsky, Andrey > > Subject: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. > > Problem: > amdgpu_ras_reserve_bad_pages was moved to amdgpu_ras_reset_gpu > because writing t

[PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-10 Thread Andrey Grodzovsky
Problem: amdgpu_ras_reserve_bad_pages was moved to amdgpu_ras_reset_gpu because writing to EEPROM during ASIC reset was unstable. But for ERREVENT_ATHUB_INTERRUPT amdgpu_ras_reset_gpu is called directly from ISR context and so locking is not allowed. Also it's irrelevant for this partilcular interr