Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-28 Thread SRINIVASAN SHANMUGAM
On 3/28/2025 8:28 PM, Alex Deucher wrote: On Thu, Mar 27, 2025 at 9:50 AM Christian König wrote: Am 27.03.25 um 10:37 schrieb SRINIVASAN SHANMUGAM: On 3/27/2025 2:54 PM, Christian König wrote: Over all this change doesn't seem to make much sense to me. Why exactly is isolation->spearhead n

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-28 Thread Alex Deucher
On Thu, Mar 27, 2025 at 9:50 AM Christian König wrote: > > Am 27.03.25 um 10:37 schrieb SRINIVASAN SHANMUGAM: > > On 3/27/2025 2:54 PM, Christian König wrote: > > Over all this change doesn't seem to make much sense to me. > > Why exactly is isolation->spearhead not pointing to the dummy kernel jo

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-27 Thread Christian König
Am 27.03.25 um 10:37 schrieb SRINIVASAN SHANMUGAM: > On 3/27/2025 2:54 PM, Christian König wrote: > Over all this change doesn't seem to make much sense to me. > Why exactly is isolation->spearhead not pointing to the dummy kernel job > we submit? Does the owner check or gang_subm

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-27 Thread Alex Deucher
On Thu, Mar 27, 2025 at 5:37 AM SRINIVASAN SHANMUGAM wrote: > > > On 3/27/2025 2:54 PM, Christian König wrote: > > > Over all this change doesn't seem to make much sense to me. > > Why exactly is isolation->spearhead not pointing to the dummy kernel job we > submit? > > Does the owner check or ga

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-27 Thread SRINIVASAN SHANMUGAM
On 3/27/2025 2:54 PM, Christian König wrote: Over all this change doesn't seem to make much sense to me. Why exactly is isolation->spearhead not pointing to the dummy kernel job we submit? Does the owner check or gang_submit check in amdgpu_device_enforce_isolation() fail to set up the spear

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-27 Thread Christian König
>>> Over all this change doesn't seem to make much sense to me. >>> Why exactly is isolation->spearhead not pointing to the dummy kernel job we >>> submit? >> Does the owner check or gang_submit check in >> amdgpu_device_enforce_isolation() fail to set up the spearhead? > I'm currently debugging

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-26 Thread Christian König
Am 26.03.25 um 14:55 schrieb Alex Deucher: > On Wed, Mar 26, 2025 at 4:13 AM Christian König > wrote: >> Am 25.03.25 um 16:24 schrieb Srinivasan Shanmugam: >>> This commit addresses the issue where the cleaner shader was not >>> correctly executed during gang submissions due to improper handling o

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-26 Thread Alex Deucher
On Wed, Mar 26, 2025 at 4:13 AM Christian König wrote: > > Am 25.03.25 um 16:24 schrieb Srinivasan Shanmugam: > > This commit addresses the issue where the cleaner shader was not > > correctly executed during gang submissions due to improper handling of > > the isolation spearhead. > > > > - Enhan

Re: [PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-26 Thread Christian König
Am 25.03.25 um 16:24 schrieb Srinivasan Shanmugam: > This commit addresses the issue where the cleaner shader was not > correctly executed during gang submissions due to improper handling of > the isolation spearhead. > > - Enhanced the `amdgpu_gfx_run_cleaner_shader_job` function to > initialize

[PATCH] drm/amdgpu: Fix Manual Execution of Cleaner Shader in Gang Submissions

2025-03-25 Thread Srinivasan Shanmugam
This commit addresses the issue where the cleaner shader was not correctly executed during gang submissions due to improper handling of the isolation spearhead. - Enhanced the `amdgpu_gfx_run_cleaner_shader_job` function to initialize `isolation->spearhead` with the job's scheduled fence for c