Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-23 Thread Ma, Jun
On 3/23/2022 2:22 PM, Paul Menzel wrote: > Dear Jun, > > > Thank you for your patch. > > Am 23.03.22 um 04:02 schrieb Ma, Jun: > >> On 3/22/2022 9:33 PM, Christian König wrote: >>> Am 22.03.22 um 13:53 schrieb Ma Jun: Correct the parameter name of amdgpu_ring_init() in header file. >>>

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Paul Menzel
Dear Jun, Thank you for your patch. Am 23.03.22 um 04:02 schrieb Ma, Jun: On 3/22/2022 9:33 PM, Christian König wrote: Am 22.03.22 um 13:53 schrieb Ma Jun: Correct the parameter name of amdgpu_ring_init() in header file. Maybe write "Sync up header and implementation to use the same param

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Ma, Jun
On 3/22/2022 9:33 PM, Christian König wrote: > Am 22.03.22 um 13:53 schrieb Ma Jun: >> Correct the parameter name of amdgpu_ring_init() in header file. > > Maybe write "Sync up header and implementation to use the same parameter > names", otherwise somebody could think that this is a real func

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Christian König
Am 22.03.22 um 13:53 schrieb Ma Jun: Correct the parameter name of amdgpu_ring_init() in header file. Maybe write "Sync up header and implementation to use the same parameter names", otherwise somebody could think that this is a real functional bug fix and backport it. Signed-off-by: Ma J

RE: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Ma Jun Sent: Tuesday, March 22, 2022 8:53 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Correct the parameter name of

[PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-22 Thread Ma Jun
Correct the parameter name of amdgpu_ring_init() in header file. Signed-off-by: Ma Jun Change-Id: I202d76ba04b137926b456b1c8a4c05a5b1a01bff --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.