Re: [PATCH] drm/amdgpu: Consolidate VCN firmware setup code

2021-10-19 Thread James Zhu
With two nit-pick below. ThispatchisReviewed-by:JamesZhu On 2021-10-19 11:56 a.m., Alex Deucher wrote: Roughly the same code was present in all VCN versions. Consolidate it into a single function. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 25 ++

[PATCH] drm/amdgpu: Consolidate VCN firmware setup code

2021-10-19 Thread Alex Deucher
Roughly the same code was present in all VCN versions. Consolidate it into a single function. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 25 + drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 ++ drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 10 +---