ct: Re: [PATCH] drm/amdgpu/vcn: fix idle work handler for VCN 2.5
Ping? This fixes a regression on VCN 2.5.
Thanks,
Alex
On Thu, Mar 6, 2025 at 10:05 AM Alex Deucher wrote:
>
> Ping?
>
> Thanks,
>
> Alex
>
> On Wed, Mar 5, 2025 at 2:42 PM Alex Deucher wrote:
> >
Ping? This fixes a regression on VCN 2.5.
Thanks,
Alex
On Thu, Mar 6, 2025 at 10:05 AM Alex Deucher wrote:
>
> Ping?
>
> Thanks,
>
> Alex
>
> On Wed, Mar 5, 2025 at 2:42 PM Alex Deucher wrote:
> >
> > VCN 2.5 uses the PG callback to enable VCN DPM which is
> > a global state. As such, we nee
Ping?
Thanks,
Alex
On Wed, Mar 5, 2025 at 2:42 PM Alex Deucher wrote:
>
> VCN 2.5 uses the PG callback to enable VCN DPM which is
> a global state. As such, we need to make sure all instances
> are in the same state.
>
> v2: switch to a ref count (Lijo)
> v3: switch to its own idle work handle
VCN 2.5 uses the PG callback to enable VCN DPM which is
a global state. As such, we need to make sure all instances
are in the same state.
v2: switch to a ref count (Lijo)
v3: switch to its own idle work handler
v4: fix logic in DPG handling
Fixes: 4ce4fe27205c ("drm/amdgpu/vcn: use per instance
On 2025-03-04 18:01, Alex Deucher wrote:
VCN 2.5 uses the PG callback to enable VCN DPM which is
a global state. As such, we need to make sure all instances
are in the same state.
v2: switch to a ref count (Lijo)
v3: switch to its own idle work handler
Fixes: 4ce4fe27205c ("drm/amdgpu/vcn: us
On Tue, Mar 4, 2025 at 11:29 AM Alex Deucher wrote:
>
> VCN 2.5 uses the PG callback to enable VCN DPM which is
> a global state. As such, we need to make sure all instances
> are in the same state.
Actually ref counting won't work because the gate and ungate calls may
not be balanced. I just s
VCN 2.5 uses the PG callback to enable VCN DPM which is
a global state. As such, we need to make sure all instances
are in the same state.
v2: switch to a ref count (Lijo)
v3: switch to its own idle work handler
Fixes: 4ce4fe27205c ("drm/amdgpu/vcn: use per instance callbacks for idle work
hand
On Tue, Mar 4, 2025 at 4:00 PM Boyuan Zhang wrote:
>
>
> On 2025-03-04 11:22, Alex Deucher wrote:
> > VCN 2.5 uses the PG callback to enable VCN DPM which is
> > a global state. As such, we need to make sure all instances
> > are in the same state.
> >
> > v2: switch to a ref count (Lijo)
> >
> >
On 2025-03-04 11:22, Alex Deucher wrote:
VCN 2.5 uses the PG callback to enable VCN DPM which is
a global state. As such, we need to make sure all instances
are in the same state.
v2: switch to a ref count (Lijo)
Fixes: 4ce4fe27205c ("drm/amdgpu/vcn: use per instance callbacks for idle work
VCN 2.5 uses the PG callback to enable VCN DPM which is
a global state. As such, we need to make sure all instances
are in the same state.
v2: switch to a ref count (Lijo)
Fixes: 4ce4fe27205c ("drm/amdgpu/vcn: use per instance callbacks for idle work
handler")
Signed-off-by: Alex Deucher
---
On 3/4/2025 7:50 PM, Alex Deucher wrote:
> VCN 2.5 uses the PG callback to enable VCN DPM which is
> a global state. As such, we need to make sure all instances
> are in the same state. Use amdgpu_device_ip_set_powergating_state()
> rather than the per instance set_pg_state() callback.
>
> Fi
VCN 2.5 uses the PG callback to enable VCN DPM which is
a global state. As such, we need to make sure all instances
are in the same state. Use amdgpu_device_ip_set_powergating_state()
rather than the per instance set_pg_state() callback.
Fixes: 4ce4fe27205c ("drm/amdgpu/vcn: use per instance cal
12 matches
Mail list logo
