RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Lazar, Lijo
c...@amd.com>>; Quan, Evan mailto:evan.q...@amd.com>>; Alex Deucher mailto:alexdeuc...@gmail.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Subject: RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan spee

Re: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Deucher, Alexander
; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback [AMD Public Use] [AMD Public Use] Is the xclk really 25 Mhz or is there some divider for the fan stuff? Changing the xclk value will affect other places where this is used. Alex

RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Lazar, Lijo
: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback [AMD Public Use] [AMD Public Use] Is the xclk really 25 Mhz or is there some divider for the fan stuff? Changing the xclk value will affect other places where this is used. Alex From: Chen, Guchun

Re: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Deucher, Alexander
-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback [AMD Public Use] In soc15_get_xclk, we have independent handling for CHIP_RAVEN case. If (adev->asic_type == CHIP_RAVEN) return reference_clock / 4; I am not sure

RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Chen, Guchun
Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Quan, Evan Sent: Wednesday, January 27, 2021 11:46 AM To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback [AMD Official Use Only -

RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Lazar, Lijo
ucher, Alexander Subject: RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback [AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Actually after switching to retrieve fan speed from metrics table always, this API is not used any more. May

RE: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Quan, Evan
Of Alex Deucher Sent: Wednesday, January 27, 2021 2:17 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback The xclk needs to be divided by 4. Fixes: acab02c1af43d3 ("drm/amdgpu/pm/smu11: Fix fan set speed bug")

[PATCH] drm/amdgpu/pm/smu11: fix static fan speed readback

2021-01-26 Thread Alex Deucher
The xclk needs to be divided by 4. Fixes: acab02c1af43d3 ("drm/amdgpu/pm/smu11: Fix fan set speed bug") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v