[PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces] (V2)

2018-12-21 Thread S, Shirish
Initializing structures with { } is known to be problematic since it doesn't necessararily initialize all bytes, in case of padding, causing random failures when structures are memcmp(). This patch fixes the structure initialisation related compiler error by memset(). V2: rectified missing peice

Re: [PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-21 Thread S
Have rectified it. I had built it but seems some how i missed it while rebasing the patch from my internal kernel tree (which is a bit older) onto internal-staging tip. Apologies for the troubles. Have sent V2, please review. Regards, Shirish S On 12/21/2018 4:48 PM, Michel Dänzer wrote: >

Re: [PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-21 Thread Koenig, Christian
Am 21.12.18 um 12:18 schrieb Michel Dänzer: > On 2018-12-20 3:01 p.m., S, Shirish wrote: >> Initializing structures with { } is known to be problematic since >> it doesn't necessararily initializes all bytes, in case of padding, >> causing random failures when structures are memcmp(). >> >> This pa

Re: [PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-21 Thread Michel Dänzer
On 2018-12-20 3:01 p.m., S, Shirish wrote: > Initializing structures with { } is known to be problematic since > it doesn't necessararily initializes all bytes, in case of padding, > causing random failures when structures are memcmp(). > > This patch fixes the structure initialisation compiler er

Re: [PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread Deucher, Alexander
/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces] Initializing structures with { } is known to be problematic since it doesn't necessararily initializes all bytes, in case of padding, causing random failures when structures are memcmp(). This patch fixes the structure initialisation com

[PATCH] drm/amdgpu/gmc: fix compiler errors [-Werror,-Wmissing-braces]

2018-12-20 Thread S, Shirish
Initializing structures with { } is known to be problematic since it doesn't necessararily initializes all bytes, in case of padding, causing random failures when structures are memcmp(). This patch fixes the structure initialisation compiler error by memsetting the entire structure elements inste