Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-02 Thread Michel Dänzer
On 2020-09-02 9:02 a.m., Daniel Vetter wrote: > On Tue, Sep 01, 2020 at 09:58:43AM -0400, Harry Wentland wrote: >> On 2020-09-01 3:54 a.m., Daniel Vetter wrote: >>> On Wed, Aug 26, 2020 at 11:24:23AM +0300, Pekka Paalanen wrote: On Tue, 25 Aug 2020 12:58:19 -0400 "Kazlauskas, Nicholas" w

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-02 Thread Daniel Vetter
On Tue, Sep 01, 2020 at 09:58:43AM -0400, Harry Wentland wrote: > > > On 2020-09-01 3:54 a.m., Daniel Vetter wrote: > > On Wed, Aug 26, 2020 at 11:24:23AM +0300, Pekka Paalanen wrote: > >> On Tue, 25 Aug 2020 12:58:19 -0400 > >> "Kazlauskas, Nicholas" wrote: > >> > >>> On 2020-08-22 5:59 a.m., M

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-01 Thread Harry Wentland
On 2020-09-01 3:54 a.m., Daniel Vetter wrote: > On Wed, Aug 26, 2020 at 11:24:23AM +0300, Pekka Paalanen wrote: >> On Tue, 25 Aug 2020 12:58:19 -0400 >> "Kazlauskas, Nicholas" wrote: >> >>> On 2020-08-22 5:59 a.m., Michel Dänzer wrote: On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote:

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-01 Thread Daniel Vetter
On Tue, Sep 01, 2020 at 10:56:42AM +0200, Michel Dänzer wrote: > On 2020-09-01 9:57 a.m., Daniel Vetter wrote: > > On Tue, Aug 25, 2020 at 04:55:28PM +0200, Michel Dänzer wrote: > >> On 2020-08-24 9:43 a.m., Pekka Paalanen wrote: > >> > >>> Sounds like the helpers you refer to are inadequate for y

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-01 Thread Michel Dänzer
On 2020-09-01 9:57 a.m., Daniel Vetter wrote: > On Tue, Aug 25, 2020 at 04:55:28PM +0200, Michel Dänzer wrote: >> On 2020-08-24 9:43 a.m., Pekka Paalanen wrote: >> >>> Sounds like the helpers you refer to are inadequate for your case. >>> Can't you fix the helpers in the long run and land this pat

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-01 Thread Daniel Vetter
On Tue, Aug 25, 2020 at 04:55:28PM +0200, Michel Dänzer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2020-08-24 9:43 a.m., Pekka Paalanen wrote: > > On Sat, 22 Aug 2020 11:59:26 +0200 Michel Dänzer > > wrote: > >> On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: > >>> On 20

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-01 Thread Daniel Vetter
On Wed, Aug 26, 2020 at 11:24:23AM +0300, Pekka Paalanen wrote: > On Tue, 25 Aug 2020 12:58:19 -0400 > "Kazlauskas, Nicholas" wrote: > > > On 2020-08-22 5:59 a.m., Michel Dänzer wrote: > > > On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: > > >> On 2020-08-21 12:57 p.m., Michel Dänzer wrot

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-26 Thread Michel Dänzer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2020-08-26 10:24 a.m., Pekka Paalanen wrote: > On Tue, 25 Aug 2020 12:58:19 -0400 "Kazlauskas, Nicholas" > wrote: > >> On 2020-08-22 5:59 a.m., Michel Dänzer wrote: >>> On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: On 2020-08-21 12:57 p

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-26 Thread Pekka Paalanen
On Tue, 25 Aug 2020 12:58:19 -0400 "Kazlauskas, Nicholas" wrote: > On 2020-08-22 5:59 a.m., Michel Dänzer wrote: > > On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: > >> On 2020-08-21 12:57 p.m., Michel Dänzer wrote: > >>> From: Michel Dänzer > >>> > >>> Don't check drm_crtc_state::acti

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-25 Thread Kazlauskas, Nicholas
On 2020-08-22 5:59 a.m., Michel Dänzer wrote: On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: On 2020-08-21 12:57 p.m., Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h:   * Hence drivers must n

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-25 Thread Michel Dänzer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2020-08-24 9:43 a.m., Pekka Paalanen wrote: > On Sat, 22 Aug 2020 11:59:26 +0200 Michel Dänzer > wrote: >> On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: >>> On 2020-08-21 12:57 p.m., Michel Dänzer wrote: From: Michel Dänzer D

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-24 Thread Pekka Paalanen
On Sat, 22 Aug 2020 11:59:26 +0200 Michel Dänzer wrote: > On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: > > On 2020-08-21 12:57 p.m., Michel Dänzer wrote: > >> From: Michel Dänzer > >> > >> Don't check drm_crtc_state::active for this either, per its > >> documentation in include/drm/drm

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-22 Thread Michel Dänzer
On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote: > On 2020-08-21 12:57 p.m., Michel Dänzer wrote: >> From: Michel Dänzer >> >> Don't check drm_crtc_state::active for this either, per its >> documentation in include/drm/drm_crtc.h: >> >>   * Hence drivers must not consult @active in their vario

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-21 Thread Kazlauskas, Nicholas
On 2020-08-21 12:57 p.m., Michel Dänzer wrote: From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various * &drm_mode_config_funcs.atomic_check callback to reject an atom

[PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-08-21 Thread Michel Dänzer
From: Michel Dänzer Don't check drm_crtc_state::active for this either, per its documentation in include/drm/drm_crtc.h: * Hence drivers must not consult @active in their various * &drm_mode_config_funcs.atomic_check callback to reject an atomic * commit. The atomic helpers disable the CRTC