Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Alex Deucher
Applied. Thanks. I forgot to add it to the commit when I pushed it, but for posterity, Fixes: 3bd68b32c911 ("drm/amdgpu: fix pipeline sync v2:) Alex On Fri, Feb 3, 2023 at 11:53 AM Bert Karwatzki wrote: > > Here is the fix for (send again to test if I can get it right with > Evolution) > Bug:

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Bert Karwatzki
Here is the fix for (send again to test if I can get it right with Evolution) Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 From: Bert Karwatzki Date: Thu, 2 Feb 2023 19:50:27 +0100 Subject: [PATCH] Fix memory leak

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Christian König
Am 02.02.23 um 20:02 schrieb Bert Karwatzki: I hope I got it right this time: Here is the fix for Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 From: Bert Karwatzki Date: Thu, 2 Feb 2023 19:50:27 +0100 Subject:

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-03 Thread Mikhail Gavrilov
On Fri, Feb 3, 2023 at 12:10 AM Bert Karwatzki wrote: > > I hope I got it right this time: > Here is the fix for > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 > > From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 > From: Bert Karwatzki > Date: Thu, 2 Feb 2023 19

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-02 Thread Bert Karwatzki
I hope I got it right this time: Here is the fix for Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 >From 6e064c9565ef0da890f3fcb2a4f6a8cd44a12fdb Mon Sep 17 00:00:00 2001 From: Bert Karwatzki Date: Thu, 2 Feb 2023 19:50:27 +0100 Subject: [PATCH] Fix memory leak in amdgpu_cs_sync_rings

Re: [PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-02 Thread Alex Deucher
On Thu, Feb 2, 2023 at 1:05 PM Bert Karwatzki wrote: > > amdgpu_sync_get_fence deletes the returned fence from the syncobj, so > the refcount of fence needs to lowered to avoid a memory leak: > https://gitlab.freedesktop.org/drm/amd/-/issues/2360 Bug: https://gitlab.freedesktop.org/drm/amd/-/issu

[PATCH] drm/amd: fix memory leak in amdgpu_cs_sync_rings

2023-02-02 Thread Bert Karwatzki
amdgpu_sync_get_fence deletes the returned fence from the syncobj, so the refcount of fence needs to lowered to avoid a memory leak: https://gitlab.freedesktop.org/drm/amd/-/issues/2360 diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 0f4cb41078c1.