Re: [PATCH] drm/amd: Fix a probing order problem on SDMA 2.4

2023-12-12 Thread Alex Deucher
On Tue, Dec 12, 2023 at 12:37 PM Alex Deucher wrote: > > On Tue, Dec 12, 2023 at 12:30 PM Mario Limonciello > wrote: > > > > commit 751e293f2c99 ("drm/amd: Move microcode init from sw_init to > > early_init for SDMA v2.4") made a fateful mistake in > > `adev->sdma.num_instances` wasn't declared w

Re: [PATCH] drm/amd: Fix a probing order problem on SDMA 2.4

2023-12-12 Thread Alex Deucher
On Tue, Dec 12, 2023 at 12:30 PM Mario Limonciello wrote: > > commit 751e293f2c99 ("drm/amd: Move microcode init from sw_init to > early_init for SDMA v2.4") made a fateful mistake in > `adev->sdma.num_instances` wasn't declared when sdma_v2_4_init_microcode() > was run. This caused probing to fai

[PATCH] drm/amd: Fix a probing order problem on SDMA 2.4

2023-12-12 Thread Mario Limonciello
commit 751e293f2c99 ("drm/amd: Move microcode init from sw_init to early_init for SDMA v2.4") made a fateful mistake in `adev->sdma.num_instances` wasn't declared when sdma_v2_4_init_microcode() was run. This caused probing to fail. Move the declaration to right before sdma_v2_4_init_microcode().