Re: [PATCH] drm/amd: Don't initialize ISP hardware without FW

2024-06-18 Thread Alex Deucher
On Tue, Jun 18, 2024 at 2:02 PM Mario Limonciello wrote: > > Although designs may contain an ISP IP block, the camera might be a USB > camera. Because of this the ISP firmware is considered optional from > amdgpu. However if the firmware doesn't get loaded the hardware should > not be initialized

RE: [PATCH] drm/amd: Don't initialize ISP hardware without FW

2024-06-18 Thread Nirujogi, Pratap
[AMD Official Use Only - AMD Internal Distribution Only] LGTM, thank you. -Original Message- From: Limonciello, Mario Sent: Tuesday, June 18, 2024 12:43 PM To: amd-gfx@lists.freedesktop.org Cc: Nirujogi, Pratap ; Limonciello, Mario Subject: [PATCH] drm/amd: Don't initializ

[PATCH] drm/amd: Don't initialize ISP hardware without FW

2024-06-18 Thread Mario Limonciello
Although designs may contain an ISP IP block, the camera might be a USB camera. Because of this the ISP firmware is considered optional from amdgpu. However if the firmware doesn't get loaded the hardware should not be initialized. Adjust the return code for early init to ensure the IP block does