Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

2019-08-22 Thread Wang, Kevin(Yang)
Subject: RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 smu_feature_update_enable_state() is used only in amdgpu_smu.c. As a common sense, these APIs should be declared as ‘static’. Regards, Evan From: Wang, Kevin(Yang) Sent: Friday, August 23, 2019 1:30 PM To

RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

2019-08-22 Thread Quan, Evan
gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Subject: RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 Comment inline From: Wang, Kevin(Yang) mailto:kevin1.w...@amd.com>> Sent: Thursday, August 22, 2019 8:00 PM To: Quan, Evan mailto:evan.q...@a

Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

2019-08-22 Thread Wang, Kevin(Yang)
comment inline From: Quan, Evan Sent: Friday, August 23, 2019 12:50 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 Comment inline From: Wang, Kevin(Yang) Sent

RE: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

2019-08-22 Thread Quan, Evan
Comment inline From: Wang, Kevin(Yang) Sent: Thursday, August 22, 2019 8:00 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 comment inline. From: amd-gfx mailto:amd-gfx-boun

Re: [PATCH] drm/amd/powerplay: update cached feature enablement status V2

2019-08-22 Thread Wang, Kevin(Yang)
comment inline. From: amd-gfx on behalf of Evan Quan Sent: Thursday, August 22, 2019 6:18 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: update cached feature enablement status V2 Need to update in cache feature

[PATCH] drm/amd/powerplay: update cached feature enablement status V2

2019-08-22 Thread Evan Quan
Need to update in cache feature enablement status after pp_feature settings. Another fix for the commit below: drm/amd/powerplay: implment sysfs feature status function in smu V2: update smu_feature_update_enable_state() and relates Change-Id: I90e29b0d839df26825d5993212f6097c7ad4bebf Signed-off-