Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Bin Li
Hi Mario, I found I missed the part in drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c with kai.heng's review. I will rebuild a new kernel and test it again, and reply later, sorry about that. On Thu, Dec 7, 2023 at 2:58 PM Kai-Heng Feng wrote: > On Thu, Dec 7, 2023 at 10:10 AM Mario

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Bin Li
Hi Mario, It's a false alarm from my side, after testing the 6.1.0-oem and 6.5.0-oem kernels, this patch works perfectly fine, sorry about that. On Thu, Dec 7, 2023 at 3:47 PM Bin Li wrote: > > Hi Mario, > > I found I missed the part in > drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Kai-Heng Feng
On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello wrote: > > On 12/6/2023 19:23, Kai-Heng Feng wrote: > > On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello > > wrote: > >> > >> On 12/5/2023 14:17, Hamza Mahfooz wrote: > >>> We currently don't support dirty rectangles on hardware rotated modes. > >>

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Kai-Heng Feng
On Thu, Dec 7, 2023 at 10:10 AM Mario Limonciello wrote: > > On 12/6/2023 20:07, Kai-Heng Feng wrote: > > On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello > > wrote: > >> > >> On 12/6/2023 19:23, Kai-Heng Feng wrote: > >>> On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello > >>> wrote: > > >>

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Kai-Heng Feng
On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: > > On 12/5/2023 14:17, Hamza Mahfooz wrote: > > We currently don't support dirty rectangles on hardware rotated modes. > > So, if a user is using hardware rotated modes with PSR-SU enabled, > > use PSR-SU FFU for all rotated planes (includin

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Hamza Mahfooz
On 12/5/23 15:29, Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU for all rotated planes (including cursor planes). Here i

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-07 Thread Mario Limonciello
Bin, KH, Thanks for the confirmation! Hamza, I think you can add a Tested-by tag for Bin too. On 12/7/2023 04:38, Bin Li wrote: Hi Mario, It's a false alarm from my side, after testing the 6.1.0-oem and 6.5.0-oem kernels, this patch works perfectly fine, sorry about that. On Thu, Dec 7, 2

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-06 Thread Mario Limonciello
On 12/6/2023 20:07, Kai-Heng Feng wrote: On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello wrote: On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardwar

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-06 Thread Mario Limonciello
On 12/6/2023 19:23, Kai-Heng Feng wrote: On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello wrote: On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU fo

Re: [PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-05 Thread Mario Limonciello
On 12/5/2023 14:17, Hamza Mahfooz wrote: We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU for all rotated planes (including cursor planes). Here is the email for the original reporter to giv

[PATCH] drm/amd/display: fix hw rotated modes when PSR-SU is enabled

2023-12-05 Thread Hamza Mahfooz
We currently don't support dirty rectangles on hardware rotated modes. So, if a user is using hardware rotated modes with PSR-SU enabled, use PSR-SU FFU for all rotated planes (including cursor planes). Cc: sta...@vger.kernel.org Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2952 Fixes: 30