[PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-21 Thread Jiapeng Chong
No functional modification involved. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:3171:2-3: Unneeded semicolon. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:3185:2-3: Unneeded semicolon. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/s

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread David Wu
On 2024-06-20 13:21, Alex Deucher wrote: On Thu, Jun 20, 2024 at 1:18 PM David Wu wrote: see inline, please David On 2024-06-20 12:50, Alex Deucher wrote: On Thu, Jun 20, 2024 at 12:07 PM David Wu wrote: I think the "break;" there is to silence the compilation warning - it is ugly but nee

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread Alex Deucher
On Thu, Jun 20, 2024 at 1:18 PM David Wu wrote: > > see inline, please > David > > On 2024-06-20 12:50, Alex Deucher wrote: > > On Thu, Jun 20, 2024 at 12:07 PM David Wu wrote: > >> I think the "break;" there is to silence the compilation warning - it is > >> ugly but needed. > > Which break? It

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread David Wu
see inline, please David On 2024-06-20 12:50, Alex Deucher wrote: On Thu, Jun 20, 2024 at 12:07 PM David Wu wrote: I think the "break;" there is to silence the compilation warning - it is ugly but needed. Which break? It looks fine to me. example here - code is fine but the compiler will com

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread Alex Deucher
On Thu, Jun 20, 2024 at 12:07 PM David Wu wrote: > > I think the "break;" there is to silence the compilation warning - it is > ugly but needed. Which break? It looks fine to me. Alex > > David > > On 2024-06-20 11:38, Alex Deucher wrote: > > Applied. Thanks! > > > > Alex > > > > On Thu, Jun

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread David Wu
I think the "break;" there is to silence the compilation warning - it is ugly but needed. David On 2024-06-20 11:38, Alex Deucher wrote: Applied. Thanks! Alex On Thu, Jun 20, 2024 at 5:07 AM Jiapeng Chong wrote: No functional modification involved. ./drivers/gpu/drm/amd/display/dc/dml2/d

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 20, 2024 at 5:07 AM Jiapeng Chong wrote: > > No functional modification involved. > > ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:3171:2-3: > Unneeded semicolon. > ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_