RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling On 2023-03-23 09:29, Christian König wrote: > Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam: >> CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o >> drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Luben Tuikov
On 2023-03-23 09:29, Christian König wrote: > Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam: >> CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o >> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with >> non-zero value always evaluates to true >> [-Werror,-Wtautological-bitw

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling [Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > > Sent: Thursday, March 23, 2023 07:37 > To: Limonciello, Mario ; Koenig, Christian > ; Deucher,

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
, Mario ; Tuikov, Luben Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling [AMD Official Use Only - General] Good catch. This is a typo The change is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Koenig

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
; Tuikov, Luben Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam: > CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise o

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Zhang, Hawking
, Hawking ; Tuikov, Luben Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam: > CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitw

Re: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Christian König
Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam: CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare] if (adev->ras_hw_enabled | AM

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Limonciello, Mario
ristian ; Deucher, Alexander > ; Li, Candice ; > Zhang, Hawking > Cc: amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling > > [Public] > > > > > -Original Message- > > From: SHANMUGAM, SRINIVA

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
ce ; Zhang, Hawking Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling [Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > > Sent: Thursday, March 23, 2023 07:32 > To: Koenig, Christian ; Deucher, Alexande

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Limonciello, Mario
IVASAN > > Subject: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling > > CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with > non-zero value always evaluates to true [-Werror,-Wtautological

[PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Srinivasan Shanmugam
CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare] if (adev->ras_hw_enabled | AMDGPU_RAS_BLOCK__DF)

[PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread Srinivasan Shanmugam
CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare] if (adev->ras_hw_enabled | AMDGPU_RAS_BLOCK__DF)